Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix detrend transforms to handle integer timestamp #155

Closed
d-a-bunin opened this issue Nov 24, 2023 · 1 comment
Closed

Fix detrend transforms to handle integer timestamp #155

d-a-bunin opened this issue Nov 24, 2023 · 1 comment
Assignees
@d-a-bunin
Labels
enhancement New feature or request
Milestone
Handling unaligne...

Comments

@d-a-bunin
Copy link
Collaborator

d-a-bunin commented Nov 24, 2023 •
edited

馃殌 Feature Request

In #148 it was found that detrend transforms fail on data with integer timestamp. It could be fixed.

Proposal

Fix tests tests/test_transforms/test_inference/test_transform/TestTransformTrain for transforms:

  • LinearTrendTransform
  • TheilSenTrendTransform

As I can see, the problem is within _OneSegmentLinearTrendBaseTransform._get_x method. It should be able to handle integer timestamp properly.

Test cases

  • Move fixed tests in tests/test_transforms/test_inference/test_transform/TestTransformTrain from fail to success category
  • Move fixed tests tests/test_transforms/test_inference/test_transform/TestInverseTransformTrain from fail to success category

Additional context

Blocked by #148.
@d-a-bunin d-a-bunin added the enhancement New feature or request label Nov 24, 2023
@d-a-bunin d-a-bunin added this to the Handling unaligned data milestone Nov 24, 2023
@d-a-bunin d-a-bunin self-assigned this Nov 27, 2023
This was referenced Nov 27, 2023
Closed
Merged
@d-a-bunin
Copy link
Collaborator Author

Closed by #163.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@d-a-bunin d-a-bunin

Labels
enhancement New feature or request
Projects
etna board
Status: Done
Milestone
Handling unaligned data
Development

Successfully merging a pull request may close this issue.

Fix detrend transforms to handle integer timestamp etna-team/etna
1 participant
@d-a-bunin