Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pipelines to handle integer timestamp #221

Closed
d-a-bunin opened this issue Jan 23, 2024 · 1 comment
Closed

Update pipelines to handle integer timestamp #221

d-a-bunin opened this issue Jan 23, 2024 · 1 comment
Assignees
@d-a-bunin
Labels
enhancement New feature or request
Milestone
Handling unaligne...

Comments

@d-a-bunin
Copy link
Collaborator

馃殌 Feature Request

Currently, pipelines doesn't support integer timestamp, we should fix that.

Proposal

  • Fix predict
    • Fix signature of predict to work with integer timestamp
    • Fix BasePipeline._make_predict_timestamps
      • Add error on mismatched types of parameters with index
    • Fix ModelPipelinePredictMixin._predict to work with integer timestamp

Test cases

  • Add tests on predict
    • Add tests on new types of parameters
    • Add tests on working with integer timestamp for all types of pipelines
  • Add tests on forecast method to work with integer timestamp for all types of pipelines

Additional context

No response
@d-a-bunin d-a-bunin added the enhancement New feature or request label Jan 23, 2024
@d-a-bunin d-a-bunin added this to the Handling unaligned data milestone Jan 23, 2024
@d-a-bunin d-a-bunin mentioned this issue Jan 30, 2024
Merged
4 tasks
@d-a-bunin d-a-bunin self-assigned this Feb 8, 2024
@d-a-bunin d-a-bunin mentioned this issue Feb 15, 2024
Merged
4 tasks
@d-a-bunin
Copy link
Collaborator Author

Closed by #241.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@d-a-bunin d-a-bunin

Labels
enhancement New feature or request
Projects
etna board
Status: Done
Milestone
Handling unaligned data
Development

No branches or pull requests
1 participant
@d-a-bunin