Tensor Dataset support #553
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renkai
force-pushed
the
tensor_dataset_support
branch
from
25adc3b
to
1c6f9db
Compare
Renkai
commented
Feb 23, 2022
|
|
||
| def data(self, batch_size): | ||
|
|
||
| arr = self.df[0] |
There was a problem hiding this comment.
From current tests, there is always only one item in self.df, not sure if it's the designed condition.
There was a problem hiding this comment.
we could double and double the dataset, and then, log the size of the pandas udf input
There was a problem hiding this comment.
you can use https://github.com/eto-ai/rikai/blob/v0.1.4/experimental/tfhub/tests/test_tfhub.py to run the test
There was a problem hiding this comment.
this does not sound right. can we check batch size and etc. ?
Renkai
force-pushed
the
tensor_dataset_support
branch
from
13341c6
to
ee0210f
Compare
eddyxu
reviewed
Mar 9, 2022
| @@ -0,0 +1,67 @@ | |||
| # Copyright 2021 Rikai Authors | |||
| data = data.batch(batch_size) | ||
| data = PandasDataset( | ||
| df, model.transform(), unpickle=is_udf, use_pil=True | ||
| ).data(batch_size) |
|
|
||
| __all__ = ["PandasDataset"] | ||
|
|
||
| from rikai.types import Image |
|
|
||
| def data(self, batch_size): | ||
|
|
||
| arr = self.df[0] |
There was a problem hiding this comment.
this does not sound right. can we check batch size and etc. ?
|
More complex than I thought, will create another branch to avoid noise during debugging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch solves
#539
and
#40