Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial token deployment creates external storage #82

Merged
merged 3 commits into from
Jan 29, 2019
Merged

Initial token deployment creates external storage #82

merged 3 commits into from
Jan 29, 2019

Conversation

peteremiljensen
Copy link
Member

@peteremiljensen peteremiljensen commented Jan 26, 2019 •
edited by truls
Loading

Closes #72 Closes #73

@peteremiljensen peteremiljensen added this to In progress in Audit Fixes via automation Jan 26, 2019
@peteremiljensen peteremiljensen force-pushed the peter/intial-storage-creation branch 2 times, most recently from acc3cbd to fff3f1c Compare January 26, 2019 15:50
@peteremiljensen peteremiljensen changed the title [WIP] At initial token deployment external storage is created automatically [WIP] Initial token deployment creates external storage Jan 26, 2019
@peteremiljensen peteremiljensen force-pushed the peter/intial-storage-creation branch 3 times, most recently from c355106 to 6146220 Compare January 27, 2019 14:05
@peteremiljensen peteremiljensen changed the title [WIP] Initial token deployment creates external storage Initial token deployment creates external storage Jan 27, 2019
truls
truls suggested changes Jan 27, 2019
View reviewed changes
Copy link
Contributor

@truls truls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments. Great work otherwise!

contracts/token/ERC20/ExternalERC20.sol Show resolved Hide resolved
test/utils.js Outdated Show resolved Hide resolved
test/token/ERC20/ExternalERC20.test.js Outdated Show resolved Hide resolved
test/token/ERC20/ExternalERC20.test.js Outdated Show resolved Hide resolved
test/token/ERC20/ExternalERC20.test.js Outdated Show resolved Hide resolved
contracts/token/ERC20/ExternalERC20Storage.sol Show resolved Hide resolved
contracts/token/EToken.sol Show resolved Hide resolved
contracts/token/ETokenExplicitSender.sol Outdated Show resolved Hide resolved
contracts/token/ETokenExplicitSender.sol Outdated Show resolved Hide resolved
contracts/token/ETokenExplicitSender.sol Outdated Show resolved Hide resolved
Audit Fixes automation moved this from In progress to Needs review Jan 27, 2019
@peteremiljensen peteremiljensen force-pushed the peter/intial-storage-creation branch 2 times, most recently from b36793d to 7cfe7d6 Compare January 29, 2019 11:21
Audit Fixes automation moved this from Needs review to Reviewer approved Jan 29, 2019
@truls truls merged commit 579ac24 into master Jan 29, 2019
Audit Fixes automation moved this from Reviewer approved to Done Jan 29, 2019
@peteremiljensen peteremiljensen deleted the peter/intial-storage-creation branch January 29, 2019 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@truls truls truls approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Audit Fixes
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peteremiljensen @truls