Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model events are not fired in Baum\Node subclasses #1

Closed
etrepat opened this issue May 7, 2013 · 1 comment
Closed

Model events are not fired in Baum\Node subclasses #1

etrepat opened this issue May 7, 2013 · 1 comment
Labels

Comments

@etrepat
Copy link
Owner

etrepat commented May 7, 2013

It seems that model events are not fired in Baum\Node subclasses. Baum\Node's are fired but it does not continue to fire additional ones.

I need to investigate Model events further.

@etrepat
Copy link
Owner Author

etrepat commented May 7, 2013

It seems from the Illuminate\Database\Eloquent\Model file, that ing events are fired in "halting" mode by default. For an Eloquent model, this means that whatever the event handler function returns (be it false or not, with the only exception of null) will actually halt the event firing chain and return that value. ¿?

All Baum\Node's events return true by default, the fix is easy enough and I don't need anything returned from the event handlers, but I don't understand the motivation behind this behaviour.

@etrepat etrepat closed this as completed in 57c63ea May 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant