Add option for image and video source to be a url. #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvanderlaat
changed the title
pvanderlaat
changed the title
clabe45
requested changes
Oct 2, 2022
| class Video extends AudioSourceMixin(VisualSourceMixin(Visual)) { | ||
| constructor (options: VisualSourceOptions) { | ||
| if (typeof (options.source) === 'string') { | ||
| const img = document.createElement('video') |
| @@ -25,7 +25,7 @@ interface VisualSource extends Visual { | |||
| } | |||
|
|
|||
| interface VisualSourceOptions extends VisualOptions { | |||
| source: HTMLImageElement | HTMLVideoElement | |||
| source: HTMLImageElement | HTMLVideoElement | string | |||
There was a problem hiding this comment.
If you revert this line and override source in ImageOptions and VideoOptions, will it still compile?
Updating ImageOptions to this:
interface ImageOptions extends VisualSourceOptions {
source: HTMLImageElement | string
}If it doesn't compile, it's fine to leave it how it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving the first two parts of the following issue by allowing visualsource to accept a string for its "source" and turn it into an HTMLElement('img') or HTMLElement('video'):
#61