Fix singleton bugs related to thread-safety and checks for sequence t…

…ypes
ets-labs · Jun 8, 2016 · 2fcfa79 · 2fcfa79
1 parent d963e9b
commit 2fcfa79
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/dependency_injector/providers/creational.py b/dependency_injector/providers/creational.py
@@ -212,12 +212,10 @@ def _provide(self, *args, **kwargs):
 
         :rtype: object
         """
-        if self.instance:
-            return self.instance
-
         with GLOBAL_LOCK:
-            self.instance = super(Singleton, self)._provide(*args, **kwargs)
-
+            if self.instance is None:
+                self.instance = super(Singleton, self)._provide(*args,
+                                                                **kwargs)
         return self.instance