Merge dc40ad8 into 69602dc

ets-labs · Mar 21, 2019 · b876830 · b876830
2 parents 69602dc + dc40ad8
commit b876830
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 6 deletions.
diff --git a/src/dependency_injector/providers.c b/src/dependency_injector/providers.c
diff --git a/src/dependency_injector/providers.pyx b/src/dependency_injector/providers.pyx
@@ -1808,7 +1808,7 @@ cdef class ThreadLocalSingleton(BaseSingleton):
 
         :rtype: None
         """
-        self.__storage.instance = None
+        del self.__storage.instance
 
     cpdef object _provide(self, tuple args, dict kwargs):
         """Return single instance."""

diff --git a/tests/unit/providers/test_singletons_py2_py3.py b/tests/unit/providers/test_singletons_py2_py3.py
@@ -347,7 +347,7 @@ def test_reset(self):
         provider.reset()
 
         instance2 = provider()
-        self.assertIsInstance(instance1, object)
+        self.assertIsInstance(instance2, object)
 
         self.assertIsNot(instance1, instance2)
 
@@ -397,6 +397,19 @@ def test_repr(self):
                              repr(Example),
                              hex(id(provider))))
 
+    def test_reset(self):
+        provider = providers.ThreadLocalSingleton(Example)
+
+        instance1 = provider()
+        self.assertIsInstance(instance1, Example)
+
+        provider.reset()
+
+        instance2 = provider()
+        self.assertIsInstance(instance2, Example)
+
+        self.assertIsNot(instance1, instance2)
+
 
 class DelegatedThreadLocalSingletonTests(_BaseSingletonTestCase,
                                          unittest.TestCase):