Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate inject decorator #136

Merged
merged 4 commits into from
Sep 22, 2016
Merged

Deprecate inject decorator #136

merged 4 commits into from
Sep 22, 2016

Conversation

rmk135
Copy link
Member

@rmk135 rmk135 commented Sep 22, 2016

Usage of @inject decorator can lead to bad design and could be considered as anti-pattern.

  • Promotion of usage of @inject decorator should be terminated (README, Docs).
  • All public examples should be redesigned / rewritten to avoid usage of @inject decorator.
  • Documentation page about @inject decorator should be left "as is", but:
    • There should be no links to it from latest version of docs.
    • There should be a warning about deprecation of functionality in the top of the page.
  • Access / usage of @inject decorator should produce a DeprecationWarning.
  • Change should be backward compatible with all 2.x.x releases.

@rmk135 rmk135 added this to the 2.2 milestone Sep 22, 2016
@rmk135 rmk135 self-assigned this Sep 22, 2016
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 38c9d2f on deprecate_inject_decorator into d9f4aed on master.

@rmk135 rmk135 merged commit 53f60d6 into master Sep 22, 2016
@rmk135 rmk135 deleted the deprecate_inject_decorator branch October 30, 2016 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants