Add Python 3.12 Support #752
Conversation
|
Hello, I am planning to use your package in my new project. But i saw that you fixed the pydantic version in requirement-dev.txt. I need to use pydantic V2. Does this fix block my usage? If yes, will you support pydantic v2 and when? |
|
@abdullah-retorio Hi, pydantic version doesn't matter, it's only for tests. I successfully use pydanticV2 and this DI in my project. |
|
Hi 👋 |
|
@rmk135 Hi, please, could you review? |
|
You might also want to update the CI config to also run tests on Python 3.12: https://github.com/ets-labs/python-dependency-injector/blob/master/.github/workflows/tests-and-linters.yml |
|
The reason why I deleted tests for an older python versions is - СPython version 3.7 and lower is no longer supported. |
|
@anton-petrov thanks a lot for the PR. For some reason, some of the tests are not passing. Also, I probably would keep Python 3.7 support for a little bit because it's still around 5% of users who haven't upgraded just yet. I'm going to merge the PR as is into a feature branch and continue working on it there. |
|
hello @rmk135 when this pr will get merge to main branch . |
|
Is there a new tag containing this ? |
|
@rmk135 Sorry for the ping, but it would be awesome if you could create a new release with this change. Also happy to help if some preparation work is needed. Just let me know 🙇 |
|
@fgreinacher see #765 |
Description
Added support for Python 3.12
All tests passed ✌️
Ready for merge.
Pinned dependencies:
Fixed Github Actions for CI and tox configuration.
Removed tests for legacy python versions, supported only CPython >= 3.8 and PyPy >= 3.9