New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use scala.js for executable and docker image #531
Conversation
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
7269070 | Encrypted Private Key | b1b020c | kinesis-mock/src/main/resources/keystore.pem | View secret |
7269071 | Encrypted Private Key | b1b020c | kinesis-mock/src/main/resources/server.json | View secret |
7269070 | Encrypted Private Key | 3ece1af | kinesis-mock/src/main/resources/keystore.pem | View secret |
7269071 | Encrypted Private Key | 3ece1af | kinesis-mock/src/main/resources/server.json | View secret |
7269122 | Generic Private Key | 3ece1af | kinesis-mock/src/main/resources/server.json | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
CC @whummer I'm currently blocked by a TLS bug in Http4s, but we are working on that. Just wanted to flag you here. If we can get this working, that means the localstack setup for kinesis-mock should simplify a heck of a lot, and remove the jdk requirement for a lot of users. I would publish the .js file as an asset that localstack can pull in and launch. Any thoughts on that from your end? Things we should think about? Node version to test in? Etc. |
Hey @etspaceman , thanks for the ping here. That sounds awesome! Getting rid of the JDK/JRE in the mid-term is something that has been in the back of our minds for some time already, and this would align nicely with your changes in here. (We currently still need Java for a couple of other services, though..) What is the timeline for this change, are you looking to get it out with a particular release? We should be able to test it on a feature branch against LocalStack, whenever you think it's ready for testing. 👍 We're currently using Node v18.16.1 inside the container. /CC Also looping in @thrau and @alexrashed here. Edit: @alexrashed just made me aware that we have this related communication thread: localstack/localstack#8680 |
Changes Introduced
Converts the project to a scala.js compliant project and uploads an executable for use as both an asset and in NPM, plus adjusts the docker image to no longer be graal-based. This should help x-platform distribution immensely, as graal had issues with M1 macs and needed to be created on a specific environment.
Applicable linked issues
#160
Checklist (check all that apply)