[WIP] Add support for authentication via SAML Proxy #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
November 7, 2016 09:44
|
I like this. It's similar to what we use internally. However, I'm not sure if I want this within 411 or just a separate plugin repo. Going to have a think about plugin architecture. |
|
I'd like to add most of this functionality directly in the |
|
That's fine with me, whatever is easiest. |
|
Hey again. Could you resubmit a PR against the https://github.com/etsy/411/tree/auth branch? I'd like to keep work on this feature there till we're done. |
|
Continuing work in #95. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is initial work to add support for running 411 behind a SAML proxy and as such bypassing the normal authentication mechanism.
This is inspired by grafana's auth.proxy https://blog.raintank.io/authproxy-howto-use-external-authentication-handlers-with-grafana/
This works but is a little ugly in some ways, any feed back on how to make it nicer would be much appreciated.