This repository has been archived by the owner on Dec 18, 2019. It is now read-only.
add an config param to override the git protocol #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me once tests are fixed. It's just checking how many times a method is called in there which is kind of a meh test but we should fix it |
|
@jayson done |
| assert_equal('https://www.testmagic.com/construction/drills.git', GitHelpers.git_url(:stack, 'https', false)) | ||
| end | ||
|
|
||
| def test_git_url_default | ||
| GitHelpers.expects(:which_github_host).returns("www.testmagic.com") | ||
| GitHelpers.expects(:git_info_for_stack).returns({:stack => {:repository => 'drills', :user => 'construction'}}) | ||
| GitHelpers.expects(:git_info_for_stack).returns({:stack => {:repository => 'drills', :user => 'construction'}}) | ||
| GitHelpers.expects(:git_info_for_stack).returns({:stack => {:repository => 'drills', :user => 'construction'}}) |
There was a problem hiding this comment.
If you delete the extra lines and add .at_least_once to the end it should fix this
|
@jgoulah made one more suggestion to get rid of silly extra lines. I tested command works if you can add that I will merge asap. Thanks again |
|
@jayson done |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the read_write param isn't passed consistently to
git_url, and there are some places where it may even be hard to pass (such asget '/head_rev/:stack')this patch is backward compatible with the current functionality but gives the user the ability to add a stack config option such as
:git_protocol => "git@",which will overwrite the default ofgit://This allows deployinator to work with private repositories without changing all the invocations of
git_url,get_git_head_revandgit_head_revand wherever else it may be called from