This repository has been archived by the owner on Dec 18, 2019. It is now read-only.
Remove etsy auth #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While this variable isn't always available - nor can we trust it in some cases - we can proxy this from another layer - such as nginx/apache - or even wrap our slim app with another application to handle authentication.
|
I can rebase if you'd like me to. It's not a single commit since I performed all the work through the github ui. |
|
Thanks for the pull request! But I'm about to push an update which will allow for implementing your own auth data retrieval function. Would love to get your input on it then. |
|
Derp. Closing this then. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't the greatest pr, but essentially we want to ensure users can specify their own authentication protocol at a different layer.
It would be nice to optionally include the EtsyInternalAuth, but I think a better solution to that would be to proxy authentication to this app from your server's sso solution. Also, no one but etsy would have that library, so including that hack would be less useful.