update checkstyle, add more settings, don't call sys.exit & more #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ sbt 1.3.8 + use scalafmt + scalatest 3.1.0 + checkstyle 8.29 + change name from `sbt-checkstyle-plugin` to `sbt-checkstyle` + use sbt-bintray instead of sbt-sonatype (If use sbt-sonatype to publish then I can't download sbt-checkstyle's `-sources.jar` in Intellij in project using sbt-checkstyle plugin)
…tyleSeverityLevel.value` and Don't call `sys.exit` when `checkstyle.value > 0`
…menting ourselves
…nfig-classpath sbt-test ``` com.puppycrawl.tools.checkstyle.api.CheckstyleException: cannot initialize module TreeWalker - TreeWalker is not allowed as a parent of LineLength Please review 'Parent Module' section for this Check in web documentation if Check is standard. at com.puppycrawl.tools.checkstyle.Checker.setupChild(Checker.java:473) ```
…Task) sequentially
+ change back checkstyleSeverityLevel default value to None + fail the build when checkstyleSeverityLevel.isDefined & checkstyle found issues has severity > checkstyleSeverityLevel + fail the build when checkstyleHeaderFile is set to non existed file + remove logPrefix
|
+1 |
|
+1 |
|
@ajsquared hey, could you provide any feedback about this PR? |
|
I no longer work at Etsy so I don't maintain this anymore. I'm not sure who is. @nixsticks do you know? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the updated README.md