support histograms #162

Dieterbe · 2012-10-08T19:18:27Z

in accordance with existing codebase, implement this in graphite
backend

Dieterbe · 2012-10-08T19:19:52Z

note that unlike traditional histograms which must have equally sized class intervals, here you can choose arbitrarily wide bins that even span to infinity, without any negative downside, should you want to. so this "bin categorisation" is actually more powerful and flexible as compared to being restricted to class intervals, but you can easily use it as a standard histogram too.

in accordance with existing codebase, implement this in graphite backend

Dieterbe · 2012-10-23T18:59:02Z

thoughts @mrtazz ?

mrtazz · 2012-10-27T04:45:13Z

If I understand it correctly, this will add a metric for timers for every bin with the corresponding frequency into graphite. However, since bin sizes are configured statically in the config, they will only fit for a subset of the data. I'm not sure if this is really helpful?

Dieterbe · 2012-10-29T04:43:28Z

well, the only other alternative I can see is some rules system where we configure the bins by matching against metric paths (similar to the method in graphites' storage-schemas.conf). I would be fine adding this (and actually considered it), but it was my understanding we didn't want statsd that configurable.

mrtazz · 2012-11-03T21:46:11Z

Yeah I think if we want to have histograms in StatsD, we need a way to define buckets based on the metrics path. I don't think they make sense otherwise.

also modify an example to demonstrate

Dieterbe · 2012-11-05T21:15:15Z

so, I just implemented that. I'm happily running this code and find it quite useful.

pro tip it's super easy to get a relative frequency expressed as % across all bins of a given metric, like so:

target=scale(divideSeries(stats.timers.render_time.bin_*,stats.timers.render_time.count),100)

mrtazz · 2012-11-11T23:09:29Z

backends/graphite.js

@@ -152,7 +173,8 @@ var backend_status = function graphite_status(writeCb) {
  }
 };

-exports.init = function graphite_init(startup_time, config, events) {
+exports.init = function graphite_init(startup_time, conf, events) {
+  config = conf


can you keep the pattern of pulling the config data in here like histogram = config.histogram or is there a need to change this?

I considered that, but IMHO a variable name like 'histogram' isn't a good name for "configuration data pertaining to histograms".

I also realized, as we add configurable behavior, it doesn't make much sense to split out bits of the config object into new objects, it also make things more complicated.

So I suggest that each backend just has a ref. to the full config object. that way new configurable logic can use the config data without needing to add more of these subsection = config.subsection things

makes sense.

Dieterbe · 2012-12-09T20:30:52Z

i updated this to be on par with master again. also I added a bunch of tests.
note: we're running the previous version in production, this version I haven't tested in production yet, but the tests are pretty extensive...

mrtazz · 2012-12-09T21:02:00Z

lib/process_metrics.js

+            freq += 1;
+          }
+          bin_name = ('bin_' + bins[bin_i]).replace('.','_');
+          current_timer_data[bin_name] = freq;


maybe it makes sense to namespace this under histogram? So that it get's added to something like current_timer_data["histogram"][bin_name], would make the namespace a bit more hierarchical.

mrtazz · 2013-01-14T11:49:14Z

stats.js

@@ -54,7 +54,8 @@ function flushMetrics() {
    sets: sets,
    counter_rates: counter_rates,
    timer_data: timer_data,
-    pctThreshold: pctThreshold
+    pctThreshold: pctThreshold,
+    histogram: config.histogram


this doesn't work. It has to be conf here. I was also wondering, since the example config puts it under the timer key this should probably be conf.timer.histogram. pctThreshold is also in the wrong spot there and I need to fix it.

mrtazz · 2013-01-14T11:50:31Z

Thanks for all the integration work! Unfortunately the histogram sub-hierarchy (though it's good and we should keep it) breaks graphite sending, since there is now an Object and the backend sends e.g. stats.timers.foo.histogram [object Object] 1358164063. Could you fix this?

Dieterbe · 2013-01-14T16:25:31Z

removed the .replace('.','_') , graphite backend probably needs to implement that now.
as for the configuration I believe this can be simplified a lot. I would suggest that the "merging with defaults, listifying" and such all gets applied to the config object (once, at startup) and then that object gets passed around to wherever the configuration is needed. there's no need to put separate config params into different vars which must then be passed separately, etc. also config should not go into the metrics variable, cause config != metrics. see the last commit in https://github.com/Dieterbe/statsd/tree/histogram-config-refactor (note that this is unfinished, breaks tests. but should show what I mean)
graphite sending stats.timers.foo.histogram [object Object] -> this is because it assumes no further deeper hierarchy when composing the statString for timer_data. i don't really have time to fix that right now. stay tuned (or feel free to fix yourself :))

Dieterbe · 2013-02-10T17:25:31Z

@mrtazz does that last commit in histogram-config-refactor look allright? it demonstrates how i think the config should be passed around. then i'll add it to the histogram branch

also slight optimisation in the metric setting loop for timers

Update to pull/209

…-integration Conflicts: backends/graphite.js exampleConfig.js

… value

mrtazz · 2013-02-19T23:45:18Z

Awesome work! Thanks for taking the time to do this!

support histograms

Dieterbe · 2013-04-04T21:26:36Z

@mrtazz it seems the "key name sanitation" never went in the graphite backend. so the decimal in the bin causes graphite to create a new dir.

/var/lib/carbon/whisper/stats/timers/render_time/histogram/bin_0
/var/lib/carbon/whisper/stats/timers/render_time/histogram/bin_1.wsp
/var/lib/carbon/whisper/stats/timers/render_time/histogram/bin_10.wsp
/var/lib/carbon/whisper/stats/timers/render_time/histogram/bin_5.wsp
/var/lib/carbon/whisper/stats/timers/render_time/histogram/bin_50.wsp
/var/lib/carbon/whisper/stats/timers/render_time/histogram/bin_inf.wsp
/var/lib/carbon/whisper/stats/timers/render_time/histogram/bin_0/01.wsp
/var/lib/carbon/whisper/stats/timers/render_time/histogram/bin_0/05.wsp
/var/lib/carbon/whisper/stats/timers/render_time/histogram/bin_0/1.wsp
/var/lib/carbon/whisper/stats/timers/render_time/histogram/bin_0/5.wsp

support histograms

Dieterbe mentioned this pull request Oct 8, 2012

"timing" has nothing to do with timing #98

Closed

Dieter Plaetinck added 2 commits October 8, 2012 15:28

support histograms

4c2ee9d

in accordance with existing codebase, implement this in graphite backend

clarify bins can be arbitrarily wide

6f51d04

Dieterbe mentioned this pull request Oct 15, 2012

samplerate support all metrics, not just counters #168

Closed

Dieter Plaetinck added 2 commits November 5, 2012 15:17

support different histogram settings for different metrics

50dd2ae

bugfix: allow bin upper limits to contain decimals

92c46c3

also modify an example to demonstrate

mrtazz reviewed Nov 11, 2012
View reviewed changes

Dieterbe added 3 commits November 12, 2012 16:07

clarify histogram/bin categorisation algorithm

6582ea2

merge branch 'master'

9308691

add tests for histograms

3fe3d43

mrtazz reviewed Dec 9, 2012
View reviewed changes

put all histogram bins in a "histogram" sub-hierarchy

7a9d9f3

mrtazz reviewed Jan 14, 2013
View reviewed changes

remove metric name sanitisation. this is a task for the backends

338fbd5

Dieterbe mentioned this pull request Jan 21, 2013

"histogram" is not a histogram, and mistake wrt timing metrics DataDog/dd-agent#349

Closed

Dieterbe and others added 3 commits February 11, 2013 18:23

bugfix: make sure histogram metric path is correct

7447b55

also slight optimisation in the metric setting loop for timers

Merge pull request statsd#248 from draco2003/master

ac2a390

Update to pull/209

Merge branch 'histogram' of github.com:Dieterbe/statsd into histogram…

3feedf2

…-integration Conflicts: backends/graphite.js exampleConfig.js

Daniel Schauenberg and others added 5 commits February 19, 2013 15:22

make histograms work with the graphite backend

f0a9361

move percentThreshold in global namespace for now

d246dab

implement graphite test for histograms

2ca3d21

remove timer subsection that was never used

08eb71a

clarify histogram graphite test: use a bin that actually includes the…

2d256e2

… value

mrtazz added a commit that referenced this pull request Feb 19, 2013

Merge pull request #162 from Dieterbe/histogram

817738f

support histograms

mrtazz merged commit 817738f into statsd:master Feb 19, 2013

Dieterbe mentioned this pull request Apr 10, 2013

Push metric name sanitization to backends #110

Closed

hbouvier pushed a commit to hbouvier/statsd that referenced this pull request May 25, 2013

Merge pull request statsd#162 from Dieterbe/histogram

f8a7213

support histograms

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

support histograms #162

support histograms #162

Dieterbe commented Oct 8, 2012

Dieterbe commented Oct 8, 2012

Dieterbe commented Oct 23, 2012

mrtazz commented Oct 27, 2012

Dieterbe commented Oct 29, 2012

mrtazz commented Nov 3, 2012

Dieterbe commented Nov 5, 2012

mrtazz Nov 11, 2012

Dieterbe Nov 12, 2012

mrtazz Nov 19, 2012

Dieterbe commented Dec 9, 2012

mrtazz Dec 9, 2012

Dieterbe Dec 9, 2012

mrtazz Jan 14, 2013

mrtazz commented Jan 14, 2013

Dieterbe commented Jan 14, 2013

Dieterbe commented Feb 10, 2013

mrtazz commented Feb 19, 2013

Dieterbe commented Apr 4, 2013

support histograms #162

support histograms #162

Conversation

Dieterbe commented Oct 8, 2012

Dieterbe commented Oct 8, 2012

Dieterbe commented Oct 23, 2012

mrtazz commented Oct 27, 2012

Dieterbe commented Oct 29, 2012

mrtazz commented Nov 3, 2012

Dieterbe commented Nov 5, 2012

mrtazz Nov 11, 2012

Choose a reason for hiding this comment

Dieterbe Nov 12, 2012

Choose a reason for hiding this comment

mrtazz Nov 19, 2012

Choose a reason for hiding this comment

Dieterbe commented Dec 9, 2012

mrtazz Dec 9, 2012

Choose a reason for hiding this comment

Dieterbe Dec 9, 2012

Choose a reason for hiding this comment

mrtazz Jan 14, 2013

Choose a reason for hiding this comment

mrtazz commented Jan 14, 2013

Dieterbe commented Jan 14, 2013

Dieterbe commented Feb 10, 2013

mrtazz commented Feb 19, 2013

Dieterbe commented Apr 4, 2013