Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statsd-proy: reset/delete state of metrics on statsd instances when ring members change [WIP] #348

Open
wants to merge 4 commits into
base: cluster_proxy
Choose a base branch
from

Conversation

joemiller
Copy link
Contributor

Sending this PR over on req from @draco2003. This code does NOT seem to work as intended. I'm not sure exactly why, I suspect perhaps there's a race condition due to metrics coming in at such a high rate, but it still seems like this approach should work.

I didn't spend too much time on it, however, as simply setting deleteIdleStats: true on the statsd side achieved roughly the same goal. Still, I think it would be desirable to have a working reset-on-ring-change function.

I could help test if someone has a better idea on how to approach this.

@joemiller joemiller mentioned this pull request Oct 3, 2013
@mrtazz
Copy link
Member

mrtazz commented Oct 4, 2013

Interesting. Is it eventually consistent or does it not work at all? I'm gonna try to find time on the weekend to poke at it.

@joemiller
Copy link
Contributor Author

No, I don't think it eventually worked. Not sure what the issue is. My
first two guesses are: race condition, or that the del* functions in
statsd were not working. I did not spend too much time on it, unfortunately.

On Fri, Oct 4, 2013 at 2:57 PM, Daniel Schauenberg <notifications@github.com

wrote:

Interesting. Is it eventually consistent or does it not work at all? I'm
gonna try to find time on the weekend to poke at it.


Reply to this email directly or view it on GitHubhttps://github.com//pull/348#issuecomment-25732825
.

@coykitten coykitten added the proxy An issue or pull request related to statsd proxies specifically label Jan 22, 2015
@hugoren
Copy link

hugoren commented Mar 3, 2016

The statsd_cluster is running. why don't it work ?
The debug is DEBUG: [1660] Warning: No backend statsd nodes available!

@shaynagar1
Copy link

Hi,
Any progress with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proxy An issue or pull request related to statsd proxies specifically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants