statsd-proy: reset/delete state of metrics on statsd instances when ring members change [WIP] #348
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sending this PR over on req from @draco2003. This code does NOT seem to work as intended. I'm not sure exactly why, I suspect perhaps there's a race condition due to metrics coming in at such a high rate, but it still seems like this approach should work.
I didn't spend too much time on it, however, as simply setting
deleteIdleStats: true
on the statsd side achieved roughly the same goal. Still, I think it would be desirable to have a working reset-on-ring-change function.I could help test if someone has a better idea on how to approach this.