statsd-proy: reset/delete state of metrics on statsd instances when ring members change [WIP]#348
statsd-proy: reset/delete state of metrics on statsd instances when ring members change [WIP]#348joemiller wants to merge 4 commits intostatsd:cluster_proxyfrom
Conversation
|
Interesting. Is it eventually consistent or does it not work at all? I'm gonna try to find time on the weekend to poke at it. |
|
No, I don't think it eventually worked. Not sure what the issue is. My On Fri, Oct 4, 2013 at 2:57 PM, Daniel Schauenberg <notifications@github.com
|
|
The statsd_cluster is running. why don't it work ? |
|
Hi, |
Sending this PR over on req from @draco2003. This code does NOT seem to work as intended. I'm not sure exactly why, I suspect perhaps there's a race condition due to metrics coming in at such a high rate, but it still seems like this approach should work.
I didn't spend too much time on it, however, as simply setting
deleteIdleStats: trueon the statsd side achieved roughly the same goal. Still, I think it would be desirable to have a working reset-on-ring-change function.I could help test if someone has a better idea on how to approach this.