-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.1.9, 0.1.10, 0.2.0 broken due to export from devDependencies #148
Comments
You have a point indeed. 1.x exposes this as a dependency instead of a dev-dependency which solves one part of it. As you said, it is probably better to avoid exposing this altogether. I'll see about create a new major 2.x that removes that dependency, since that would be a breaking change. For 0.x, since a minor in 0.x world can break, I'll see about release a 0.3.0 Cheers for that |
…`makeExecutableSchema` Including makeExecutableSchema from graphql-tools had an advantage: we could be sure that the function exported was compatible. There is a downside: many people won't need it and it is big enough to grant listening to the concerns raised in #148 and remove it altogether BREAKING CHANGE: remove `makeExecutableSchema` from the exported functions, remove @graphql-tools/schema from the dependencies re #148
Alternatively you could release |
…`makeExecutableSchema` Including makeExecutableSchema from graphql-tools had an advantage: we could be sure that the function exported was compatible. There is a downside: many people won't need it and it is big enough to grant listening to the concerns raised in #148 and remove it altogether BREAKING CHANGE: remove `makeExecutableSchema` from the exported functions, remove graphql-tools from the dependencies re #148
…`makeExecutableSchema` Including makeExecutableSchema from graphql-tools had an advantage: we could be sure that the function exported was compatible. There is a downside: many people won't need it and it is big enough to grant listening to the concerns raised in #148 and remove it altogether BREAKING CHANGE: remove `makeExecutableSchema` from the exported functions, remove graphql-tools from the dependencies re #148
…`makeExecutableSchema` Including makeExecutableSchema from graphql-tools had an advantage: we could be sure that the function exported was compatible. There is a downside: many people won't need it and it is big enough to grant listening to the concerns raised in #148 and remove it altogether BREAKING CHANGE: remove `makeExecutableSchema` from the exported functions, remove @graphql-tools/schema from the dependencies re #148
I'm submitting a ...
[x] bug report
[ ] feature request
[ ] question about the decisions made in the repository
[ ] question about how to use this project
Summary
PR #115 broke the module by exporting a member of devDependency
graphql-tools
.I recommend against adding
graphql-tools
to the dependency list for people, like me, who don't need it.If you switch to ESLint a rule could be added to avoid this in the future.
Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)
The text was updated successfully, but these errors were encountered: