Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid parsing issues with null/non-null fields #29

Closed
eturino opened this issue Dec 20, 2019 · 1 comment
Closed

Avoid parsing issues with null/non-null fields #29

eturino opened this issue Dec 20, 2019 · 1 comment

Comments

@eturino
Copy link
Owner

eturino commented Dec 20, 2019

As mentioned by @brabeji in #28, this link should not be responsible for making GraphQLErrors when the response encounters a null on a non-null field. There could be valid reasons for that, for example with some directives. In any case, this link should not be the judge of that.

We should remove those validations and their tests
@eturino eturino mentioned this issue Dec 20, 2019
Merged
eturino added a commit that referenced this issue Dec 22, 2019
@eturino
refactor: avoid type assertion
c7997cc 
ref #29 #28
@eturino
Copy link
Owner Author

eturino commented Dec 22, 2019

closed by #28

@eturino eturino closed this as completed Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eturino