fix: Handle null values for optional types #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change `apollo-link-scalars` will error for valid `null` values of nullable types with hard to track down errors like: ``` TypeError: String cannot represent a non string value: null ``` With this change, I'm able to get `apollo-link-scalars` for my project.
eturino
reviewed
Dec 5, 2019
| @@ -169,7 +169,7 @@ describe("scalar returned directly from first level queries", () => { | |||
| expect.assertions(1); | |||
| }); | |||
|
|
|||
| it("override the scala resolvers with the custom functions map", done => { | |||
| it("override the scalar resolvers with the custom functions map", done => { | |||
eturino
reviewed
Dec 5, 2019
| @@ -66,6 +66,8 @@ export class Parser { | |||
| fieldNode: ReducedFieldNode | |||
| ): any { | |||
| const type = ensureNullableType(value, givenType, fieldNode); | |||
| if (isNone(value)) return value; | |||
There was a problem hiding this comment.
good point. Originally I was thinking of allowing some custom parsing on nulls on scalars. Later I decided against it but I never went back and change the code. Nice one.
eturino
approved these changes
Dec 5, 2019
|
@gsamokovarov nice one. Thanks! |
eturino
changed the title
eturino
changed the title
|
v0.1.4 released with this fix |
|
Thank you for the quick reaction! |
|
|
|
@all-contributors please add @gsamokovarov for bug, tests and code |
|
I've put up a pull request to add @gsamokovarov! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, I'm not able to get
apollo-link-scalarsrunning in my project.This is a bugfix.
apollo-link-scalarserrors for validnullvalues of nullable types with errors like:The errors are hard to track down as they occur during the Apollo client initialization.
apollo-link-scalarswon't error on nullable scalar types anymore.