Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CZ: invalid iat field #243

Closed
JChrist opened this issue May 28, 2021 · 8 comments
Closed

CZ: invalid iat field #243

JChrist opened this issue May 28, 2021 · 8 comments
Labels
member state data issue

Comments

@JChrist
Copy link

JChrist commented May 28, 2021

Affected Country: CZ

Issue Description

All json test data provided by CZ contain an iat that is later than the contained VALIDATIONCLOCK

Proposed Solution

Please amend the test data to contain iat field earlier than the VALIDATIONCLOCK
@teiwacz
Copy link
Contributor

teiwacz commented May 31, 2021

Can you please clarify what iat stands for. Thank you.

@JChrist
Copy link
Author

JChrist commented May 31, 2021

The time when the certificate was created, as defined by the spec here

SchulzeStTSI pushed a commit that referenced this issue May 31, 2021
@teiwacz @Teiwacz-Principal
Fix VALIDATIONCLOCK in test files #243 (#257)
b1f4241 
* Fix #227  gnt & gnt in upper case
Fix #172 certificate & UTF-8 encoding
Fix RAT fields, Removal of ma from NAAT

* Removal of BOM on files

* Fix VALIDATIONCLOCK for tests and iat as UTC time in cwt

Co-authored-by: Jan Tyr <jan.tyr@principal.cz>
@teiwacz
Copy link
Contributor

teiwacz commented Jun 1, 2021

Hello, can you recheck the issue. The pull should fix that. Thx

@SchulzeStTSI
Copy link
Collaborator

@JChrist Can we close the issue?

@JChrist
Copy link
Author

JChrist commented Jun 3, 2021

I checked again with latest main branch (commit: 3b8e929), however I still had failures for CZ iat field in 1.json and 3.json.
For 1.json:
Certificate is NOT issued YET! now:2021-05-31 14:11:37.501563Z iat:2021-05-31 17:11:38.000

For 3.json:
Certificate is NOT issued YET! now:2021-05-31 14:04:23.803752Z iat:2021-05-31 17:04:24.000

@teiwacz
Copy link
Contributor

teiwacz commented Jun 3, 2021

Hello are you sure that when you are loading time that you are loading it as UTC not your local time as the diff between times are +3h (Greece local). Thanks for check.

@JChrist
Copy link
Author

JChrist commented Jun 3, 2021

While it is printed as Greek local time, it is not loaded as such, since iat field is seconds since epoch

@teiwacz
Copy link
Contributor

teiwacz commented Jun 3, 2021

Ok, looks like it's problem with rounding secs in epoch, I will fix the validationclock time. Change will be available right after builds will work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
member state data issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JChrist @SchulzeStTSI @teiwacz