Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] QR-Codes of type TEST with "TEST Result = Detected" are evaluated as cryptographically invalid. #55

Closed
RalicaY opened this issue May 27, 2021 · 11 comments · Fixed by #66
Assignees
Labels
bug Something isn't working

Comments

@RalicaY
Copy link
Collaborator

RalicaY commented May 27, 2021

Describe the bug

QR-Code of type TEST with TEST Result = Detected are evaluated as cryptographically invalid.

Expected behaviour

QR-Code of type TEST with TEST Result = Detected should evaluate to invalid with reason "Test result positive" and the affected part of the dataset incl. "test result = DETECTED" should be shown.

Steps to reproduce the issue

Scan a QR-Code of Type Test with TEST RESULT = DETECTED

Technical details

Galaxy XCover 4, Modellnummer: SM-G390F,
Android-Version: 9,

Possible Fix

Additional context

@RalicaY RalicaY added the bug Something isn't working label May 27, 2021
@RalicaY RalicaY changed the title QR-Code of type TEST with TEST Result = Detected should evaluate to invalid with reason "Test result positive" and the affected part of the dataset must be shown QR-Code of type TEST with TEST Result = Detected are evaluated as cryptographically invalid. May 27, 2021
@RalicaY RalicaY changed the title QR-Code of type TEST with TEST Result = Detected are evaluated as cryptographically invalid. QR-Code of type TEST with "TEST Result = Detected" are evaluated as cryptographically invalid. May 27, 2021
@RalicaY RalicaY changed the title QR-Code of type TEST with "TEST Result = Detected" are evaluated as cryptographically invalid. [Android] QR-Code of type TEST with "TEST Result = Detected" are evaluated as cryptographically invalid. May 28, 2021
@RalicaY RalicaY changed the title [Android] QR-Code of type TEST with "TEST Result = Detected" are evaluated as cryptographically invalid. [Android] QR-Codes of type TEST with "TEST Result = Detected" are evaluated as cryptographically invalid. May 28, 2021
@oleksandrsarapulovgl oleksandrsarapulovgl self-assigned this May 28, 2021
@oleksandrsarapulovgl
Copy link
Contributor

@RalicaY Could you please share QR code to reproduce it?

@RalicaY
Copy link
Collaborator Author

RalicaY commented May 28, 2021

Example with TEST RESULT = DETECTED
Example_Detected

@RalicaY
Copy link
Collaborator Author

RalicaY commented May 28, 2021

Exactly the same example as above but only TEST RESULT = NOT DETECTED
Example_Not_detected

@RalicaY
Copy link
Collaborator Author

RalicaY commented May 28, 2021

@oleksandrsarapulovgl , just as additional info: in both of the above examples, all optional fields were filled with data. No optional fields were left empty.

@RalicaY
Copy link
Collaborator Author

RalicaY commented May 28, 2021

@oleksandrsarapulovgl, we expect that in the first example where COVID is DETECTED, that it would be invalid with displayed reason: "Test result positive" and the data set that refers to the positive result would be displayed also in accordance with the specification: "In case of a failed verification (RED), the app should only display the reason for the fail, including details such as the specific contents or technical details of the certificate that are preventing the successful verification"

@oleksandrsarapulovgl
Copy link
Contributor

@Hendrik-Schmidt-Schierhorn-TSI could you please confirm required changes?

@oleksandrsarapulovgl
Copy link
Contributor

@RalicaY by the way, is there a chance you could share a screenshot or design of how proper displaying would be shown? Maybe from iOS application?

@oleksandrsarapulovgl
Copy link
Contributor

@oleksandrsarapulovgl
Copy link
Contributor

@RalicaY Could you please clarify the right text for test result is positive problem?

In this ticket you wrote: "Test result positive", but in this: #39 - "The test result is positive.".

Could you please clarify which one to use?

@RalicaY
Copy link
Collaborator Author

RalicaY commented Jun 1, 2021

@oleksandrsarapulovgl "Test result positive"

@kerstin-oppermann-tsi
Copy link

image
fixed, retested in release 1.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants