Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In case of a failed verification (RED), the app should only display the reason for the fail #39

Closed
RalicaY opened this issue May 18, 2021 · 10 comments · Fixed by #48
Closed
Assignees
Labels
bug Something isn't working

Comments

@RalicaY
Copy link
Collaborator

RalicaY commented May 18, 2021

Describe the bug

Despite a failed verification, the verifier app shows the certificate data set and no reason for failure is shown.

Expected behaviour

In case of a failed verification (RED), the app should only display the reason for the fail.

Steps to reproduce the issue

  1. Open verifier app;
  2. Scan a QR-Code for an invalid certificate.

Technical details

Galaxy XCover 4, Modellnummer: SM-G390F,
Android-Version: 9, Verifier App 1.0.0

Possible Fix

Additional context

@RalicaY RalicaY added the bug Something isn't working label May 18, 2021
@ltranvan
Copy link

Additional info: This behaviour decribed above occures just only for Android-VerifierApp.
IOS-VerifierApp shows only the reason(s) of the failed check (without showing any further datas of the vaccination and the vaccinated person).

@oleksandrsarapulovgl oleksandrsarapulovgl self-assigned this May 20, 2021
@oleksandrsarapulovgl
Copy link
Contributor

@ltranvan could you please provide specific QRs and specific expected errors to be displayed?

@ltranvan
Copy link

ltranvan commented May 20, 2021

@ltranvan could you please provide specific QRs and specific expected errors to be displayed?

I have asked @RalicaY to give you the info needed. But in general I would expect that Android-Verifer would list the same error message (only the error message of the failed signature-check and NOT the data set!) as displayed by IOS, wouldn't it?

@RalicaY RalicaY reopened this May 20, 2021
@RalicaY
Copy link
Collaborator Author

RalicaY commented May 20, 2021

QR_TestPositive

@RalicaY
Copy link
Collaborator Author

RalicaY commented May 20, 2021

This Certificate is invalid. The reason is: "The test result is positive."

@RalicaY
Copy link
Collaborator Author

RalicaY commented May 20, 2021

iOS_Verifier

After scanning the above invalid QR Code with the iOS Verifier App -- the reason for invalidation is displayed: "The test result is positive."

@RalicaY
Copy link
Collaborator Author

RalicaY commented May 20, 2021

Other specific Errors to be displayed are: "The cryptographic Signature is invalid.", "The test date is in the future", etc.

@oleksandrsarapulovgl
Copy link
Contributor

PR: #48

@oleksandrsarapulovgl
Copy link
Contributor

@kerstin-oppermann-tsi
Copy link

image
retested in release 1.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants