Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"In case of a failed verification (RED), the app should only display the reason for the fail, including details such as the specific contents or technical details of the certificate that are preventing the successful verification #78

Closed
RalicaY opened this issue May 19, 2021 · 7 comments
Assignees
Labels
bug Something isn't working further input needed Issue requires more input from the creator to be processed good first issue

Comments

@RalicaY
Copy link
Collaborator

RalicaY commented May 19, 2021

Describe the bug

Despite a failed verification, the verifier app shows the certificate data set, additionally to the reason for failure.

Expected behaviour

In case of a failed verification (RED), the app should only display the reason for the fail including details such as the specific contents or technical details of the certificate that are preventing the successful verification.

Steps to reproduce the issue

  1. Open verifier app;
  2. Scan a QR-Code for an invalid certificate.

Technical details

iPhone 8 plus v. Lutz, Model MQ8P2ZD/A, iOS 14.4

Possible Fix

Additional context

@RalicaY RalicaY added the bug Something isn't working label May 19, 2021
@yspreen
Copy link
Contributor

yspreen commented May 19, 2021

As per @joerg-oppermann-tsi

@yspreen yspreen closed this as completed May 19, 2021
@rebwalz rebwalz reopened this May 21, 2021
@rebwalz
Copy link

rebwalz commented May 21, 2021

bug is still open. should be fixed in one of the next versions.

@yspreen
Copy link
Contributor

yspreen commented May 21, 2021

We decided not to fix it since the logic to omit all non-error fields when there is some other error is a bit too much... how does Android handle this

@rebwalz
Copy link

rebwalz commented May 21, 2021

see #39
But this behavior is also wrong.

@yspreen yspreen added further input needed Issue requires more input from the creator to be processed good first issue and removed bug Something isn't working labels May 22, 2021
@yspreen
Copy link
Contributor

yspreen commented May 22, 2021

Removing the label since it's not a "bug", as the behavior is expected but not according to the current specification.

Since the specification is inconsistent, we need to work that out before continuing work on this ticket

@RalicaY RalicaY changed the title In case of a failed verification (RED), the app should only display the reason for the fail "In case of a failed verification (RED), the app should only display the reason for the fail, including details such as the specific contents or technical details of the certificate that are preventing the successful verification May 28, 2021
@azotlichid
Copy link

Verification seems to fail even on some valid certificates. Refusing to give the reason for failure will be disastrous, as several national authorities seem to rely on this implementation.

@RalicaY
Copy link
Collaborator Author

RalicaY commented Jul 13, 2021

At the moment the iOS and the Android version diverge.

Please, implement the same behaviour in iOS as it is in Android or a decision that the difference should remain should be communicated, in order to close this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working further input needed Issue requires more input from the creator to be processed good first issue
Projects
None yet
Development

No branches or pull requests

6 participants