By omitting the name a QR Code with invalid schema is generated

[RalicaY]

Describe the bug

If the name is omitted (it is NULL value) the issuer app generates a QR-Code with an invalid Schema. Das kann von iOS nicht eingelesen werden, während Android da

A sample QR Code and the data to generate it is attached,

Expected behaviour

Steps to reproduce the issue

Technical details:

Windows, Chrome

Possible Fix

Additional context

[ggrund-tsi]

Hi, at the moment it looks like an iOS issue because the generated JSON is valid. (otherwise the qr-code will not be generated)
Not all name input fields are mandatory or required.
Maybe it is faster when we try to reproduce it toghether.
Regards, Gordon

[yspreen]

The Schema is not valid for us. It reads ‚null is not of type string‘

On Fri, May 21, 2021 at 10:44 AM ggrund-tsi ***@***.***> wrote: Hi, at the moment it looks like an iOS issue because the generated JSON is valid. (otherwise the qr-code will not be generated) Not all name input fields are mandatory or required. Maybe it is faster when we try to reproduce it toghether. Regards, Gordon — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#81 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADAL3Z57WEHMJZMP5HCKQPDTOYMOPANCNFSM45IWHF5A> .

-- Yannick Spreen

[RalicaY]

Additional information:

• The DGCA Android Verifier App reads the code but renders the certificate invalid, although the test ist negative and the signature is verifiable.

• The IBM Verifier App does not read the code either.

[yspreen]

It’s not really an iOS issue. A string field should not be null. It can be omitted, but not null?

On Fri, May 21, 2021 at 11:31 AM RalicaY ***@***.***> wrote: Additional information: The DGCA Android Verifier App reads the code but renders the certificate invalid, although the test ist negative and the signature is verifiable. The IBM Verifier App does not read the code either. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#81 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADAL3Z3QN37II5D7OVLBZMLTOYSARANCNFSM45IWHF5A> .

-- Yannick Spreen

[ggrund-tsi]

Then I gess we have an translation issue. In TypeScript the non required name fields are not 'null'. They are 'undefined'.
And undefined fields are ignored in JSON. And it is valid with validator from jsonschema.
e.g.:
"nam": {
"fnt": "SOME<NAME"
}

What you expect?
Like this?
"nam": {
"fnt": "SOME<NAME",
"gnt": null,
"fn": null,
"gn": null
}

Or like this:
Like this?
"nam": {
"fnt": "SOME<NAME",
"gnt": "",
"fn": "",
"gn": ""
}

Last example is imho not correct.

Regards, Gordon

[yspreen]

Will be closed by the PR above. Thanks @ggrund-tsi

[RalicaY]

The problem persists in the current iOS Verifier App 1.0.1 available in App Center as of 26.05.21

[yspreen]

That's because it's not fixed in 1.0.1, but in the current main branch. Please ask Hendrik what code he used for the release, because this cannot be fixed if he used the 1.0.1 tag. Thanks

[Hendrik-Schmidt-Schierhorn-TSI]

1.0.1 is officially our current version. Let us get in touch to solve this asap.

[yspreen]

Well did you use the main branch to build or not? I can create v1.0.2 with all these changes, but it needs to be approved, merged, you have to make a new build, upload it, not sure if it's worth it for this small issue. It'll be in the next release regardless. But since it's fixed in main, I think we can close the issue here

[Hendrik-Schmidt-Schierhorn-TSI]

Of course I used the main-branch. Let us talk later directly about this, please.

[yspreen]

Oh okay! Thanks for clarifying. It's a legitimate concern then, I'll investigate this. Thanks Hendrik

[yspreen]

It's a problem with the release, not with the code. It's confirmed working on the main branch:

[Hendrik-Schmidt-Schierhorn-TSI]

I updated the Test-App with the actual App-Core-Version.

[RalicaY]

I confirm, the correction has worked and the bug is no more there with the Verfier App 1.0.1 (3)