Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated host URL for wallet app #31

Merged
merged 8 commits into from May 25, 2021
Merged

Updated host URL for wallet app #31

merged 8 commits into from May 25, 2021

Conversation

oleksandrsarapulovgl
Copy link
Contributor

No description provided.

@oleksandrsarapulovgl oleksandrsarapulovgl mentioned this pull request May 20, 2021
Closed
@yspreen
Copy link

yspreen commented May 20, 2021

Why is the URL hardcoded? That should not be the case. We have a context file for a reason @MykhailoNester @oleksandrsarapulovgl

ascheibal
ascheibal requested changes May 20, 2021
View reviewed changes
Copy link

@ascheibal ascheibal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the wallet-context.jsonc as for cert pinning we have to use it also.

@oleksandrsarapulovgl
Copy link
Contributor Author

Why is the URL hardcoded? That should not be the case. We have a context file for a reason @MykhailoNester @oleksandrsarapulovgl

Because it make sense, and there was no related requirement - that HOST url might be floating. I'll open the issue for that and implement it

@oleksandrsarapulovgl
Copy link
Contributor Author

Please use the wallet-context.jsonc as for cert pinning we have to use it also.

It's not so quick task to implement. Let's merge this, and I'll implement dynamic host fetching in scope of: eu-digital-green-certificates/dgca-verifier-app-android#40

?

@oleksandrsarapulovgl
Copy link
Contributor Author

@ascheibal I updated logic to use dynamic urls for requests. Could you please review once again?

@oleksandrsarapulovgl oleksandrsarapulovgl merged commit ceeb02c into main May 25, 2021
@oleksandrsarapulovgl oleksandrsarapulovgl deleted the feature/wallet-issuer-app-url-change branch May 25, 2021 08:12
@oleksandrsarapulovgl oleksandrsarapulovgl mentioned this pull request May 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MykhailoNester MykhailoNester MykhailoNester approved these changes

@ascheibal ascheibal ascheibal approved these changes

@SchulzeStTSI SchulzeStTSI Awaiting requested review from SchulzeStTSI

@joerg-oppermann-tsi joerg-oppermann-tsi Awaiting requested review from joerg-oppermann-tsi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oleksandrsarapulovgl @yspreen @MykhailoNester @ascheibal