Conditionally use Linux or OSX libc definitions #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, though to avoid regressing we should at least run build + unit tests on macOS (which travis-ci conveniently does support). Integ might work out of the box, but building is the more important thing to make sure this doesn't regress. |
|
Oh cool, I didn't know Travis supported that! I'll fix the config here in a bit and see whether integ will run or no. |
LinuxMercedes
force-pushed
the
osx
branch
2 times, most recently
from
352072f
to
a183366
Compare
euank
reviewed
Nov 9, 2018
LinuxMercedes
force-pushed
the
osx
branch
3 times, most recently
from
7cc0bf8
to
ffb3381
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #91
This works for me (x86_64 linux) and @lclarkmichalek (x86_64 OSX), so I think this change should be fine.