Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Link when alerting multiple recipients of a PM #67

Closed
jnschrag opened this issue Dec 10, 2013 · 6 comments
Closed

Incorrect Link when alerting multiple recipients of a PM #67

jnschrag opened this issue Dec 10, 2013 · 6 comments
Assignees
Labels
Milestone

Comments

@jnschrag
Copy link
Contributor

My apologies if this was mentioned, but I did a quick search through other issues and didn't see it.

So I installed myAlerts and a few of the expansion plugins. I was testing it out when I realized that myAlerts doesn't change the PM link when the PM was sent to multiple people. For example:

Person A sends a PM to Person B and Person C.

Both Person B and Person C receive the PM and the alert. However, when Person C clicks on the link to view the PM in his alert, he is given an invalid PM id number.

When myBB sends multiple PMs, it's multiple rows in the DB. Is there a quick fix to having myBB get the correct pmid for the correct person when showing the alert?

@euantorano
Copy link
Contributor

Wow, I'm surprised this hasn't been mentioned until now. It's definitely something I will need to look into as that certainly will cause issues. It'll be tomorrow before I get a chance to look though, at the earliest.

@jnschrag
Copy link
Contributor Author

I'm surprised too, but thanks for taking a look at it. It isn't an urgent issue, but I know if I use this on a live board and not a test board, my members will freak out getting an error like that consistently. I'll look around and see if I can find a way to pull the individual pmid's from the pm Handler, but I definitely appreciate the help!

@euantorano
Copy link
Contributor

I'm hoping it's easily accessible without running another query, but things are rarely that simple.

@jnschrag
Copy link
Contributor Author

I've done some playing around with it, and I'm not sure that it's something that can be done without an extra query. In the mean time, I've just turned that particular alert off, but I'll keep playing with it in my spare time. If I stumble upon a solution, I'll be sure to push it here.

@euantorano
Copy link
Contributor

Thanks, I'll try to find a solution over the coming week too.
On 13 Dec 2013 19:08, "jnschrag" notifications@github.com wrote:

I've done some playing around with it, and I'm not sure that it's
something that can be done without an extra query. In the mean time, I've
just turned that particular alert off, but I'll keep playing with it in my
spare time. If I stumble upon a solution, I'll be sure to push it here.


Reply to this email directly or view it on GitHubhttps://github.com//issues/67#issuecomment-30534798
.

euantorano added a commit that referenced this issue Nov 30, 2014
euantorano added a commit that referenced this issue Nov 30, 2014
@euantorano
Copy link
Contributor

Fixed, at long last. I'm sure paid never used to be an array, but it seems to be now. All is now well again.

@euantorano euantorano added the bug label Nov 30, 2014
@euantorano euantorano self-assigned this Nov 30, 2014
@euantorano euantorano added this to the v2.0.0-gold milestone Nov 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants