New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magic search to replace filter forms and text search bar #1223

Closed
wants to merge 66 commits into
base: master-4.2
from

Conversation

Projects
None yet
3 participants
@dkavanagh

This comment has been minimized.

Show comment
Hide comment
@dkavanagh

dkavanagh Jan 8, 2015

Member

@kamalgill With the last commit, I noticed that the click listener that response when someone clicks outside of the input box is broken. This is probably because the listener is on "search-main-area" and now that isn't a fixed width, but only contains the facets and input.
I also notice things aren't as tight as before. Worse on FF than Chrome. I see facets lower and icons higher and the search-bar is taller than it needs to be with a single row. Try on FF to see it more exaggerated.

Member

dkavanagh commented Jan 8, 2015

@kamalgill With the last commit, I noticed that the click listener that response when someone clicks outside of the input box is broken. This is probably because the listener is on "search-main-area" and now that isn't a fixed width, but only contains the facets and input.
I also notice things aren't as tight as before. Worse on FF than Chrome. I see facets lower and icons higher and the search-bar is taller than it needs to be with a single row. Try on FF to see it more exaggerated.

@kyolee310

This comment has been minimized.

Show comment
Hide comment
@kyolee310

kyolee310 Jan 12, 2015

Contributor

The selenium automated test is failing consistently at Volume and IP tests when trying to look up the search filter, http://10.111.4.12/job/Koala-SUITE/1387/.

The travis CI test's JavsScript Unittest is also failing as well.

Contributor

kyolee310 commented Jan 12, 2015

The selenium automated test is failing consistently at Volume and IP tests when trying to look up the search filter, http://10.111.4.12/job/Koala-SUITE/1387/.

The travis CI test's JavsScript Unittest is also failing as well.

dkavanagh and others added some commits Jan 14, 2015

GUI-1472
fixed tag search
GUI-1472
refactored menu close for better re-use. Fixed some cases where instant search should reset so table shows again
GUI-1472
only show facet menu if no facet is selected yet
@kyolee310

This comment has been minimized.

Show comment
Hide comment
@kyolee310

kyolee310 Jan 20, 2015

Contributor

Passed the automated test.

Contributor

kyolee310 commented Jan 20, 2015

Passed the automated test.

@kamalgill

This comment has been minimized.

Show comment
Hide comment
@kamalgill

kamalgill Jan 27, 2015

Member

@dkavanagh: ms_remove isn't as clear as magicsearch_remove_text, for example

Member

kamalgill commented on 08b8638 Jan 27, 2015

@dkavanagh: ms_remove isn't as clear as magicsearch_remove_text, for example

@dkavanagh dkavanagh closed this Jan 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment