Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magic search to replace filter forms and text search bar #1223

Closed
wants to merge 66 commits into from

Conversation

dkavanagh
Copy link
Member

@dkavanagh
Copy link
Member Author

@kamalgill With the last commit, I noticed that the click listener that response when someone clicks outside of the input box is broken. This is probably because the listener is on "search-main-area" and now that isn't a fixed width, but only contains the facets and input.
I also notice things aren't as tight as before. Worse on FF than Chrome. I see facets lower and icons higher and the search-bar is taller than it needs to be with a single row. Try on FF to see it more exaggerated.

@kyolee310
Copy link
Contributor

The selenium automated test is failing consistently at Volume and IP tests when trying to look up the search filter, http://10.111.4.12/job/Koala-SUITE/1387/.

The travis CI test's JavsScript Unittest is also failing as well.

@kyolee310
Copy link
Contributor

Passed the automated test.

@dkavanagh dkavanagh closed this Jan 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants