Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magic search to replace filter forms and text search bar #1223

wants to merge 66 commits into from


dkavanagh added 30 commits Oct 14, 2014
converted to GUI that looks very close to the VisualSearch bar
tweaked per UX review, allow all facet options to be selected
tightened up layout
fixed several items in list
Copy link
Member Author

@dkavanagh dkavanagh commented Jan 8, 2015

@kamalgill With the last commit, I noticed that the click listener that response when someone clicks outside of the input box is broken. This is probably because the listener is on "search-main-area" and now that isn't a fixed width, but only contains the facets and input.
I also notice things aren't as tight as before. Worse on FF than Chrome. I see facets lower and icons higher and the search-bar is taller than it needs to be with a single row. Try on FF to see it more exaggerated.

Copy link

@kyolee310 kyolee310 commented Jan 12, 2015

The selenium automated test is failing consistently at Volume and IP tests when trying to look up the search filter,

The travis CI test's JavsScript Unittest is also failing as well.

dkavanagh and others added 12 commits Jan 14, 2015
…isibility of free-text entry
fixed tag search
refactored menu close for better re-use. Fixed some cases where instant search should reset so table shows again
only show facet menu if no facet is selected yet
Copy link

@kyolee310 kyolee310 commented Jan 20, 2015

Passed the automated test.


This comment has been minimized.

Copy link

@kamalgill kamalgill commented on 08b8638 Jan 27, 2015

@dkavanagh: ms_remove isn't as clear as magicsearch_remove_text, for example

@dkavanagh dkavanagh closed this Jan 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.