Various tweaks #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous ordering is equivalent to writing
let phrases = ["nightly", "beta"];
whereas we want to pick up the dev compilers and then convert the
version identifier we found to nightly.
The main binary probably doesn't need to care about this.
The arg is passed except if --no-link-dead-code is given to the commands. See huonw/travis-cargo#49.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes (I believe) all the various features/bug-fixes in the Python version since you started this Rust one. There's a few other things too, but overall it seems pretty good to me! Nicer than the python version in a few notable spots.
I've tried to have each thing as a different commit so you can choose freely what you want.
Unfortunately, I'm starting a job where I'm unlikely to be able to do much open source code, which means I won't be able to manage this, but I'm very happy for you to, and will try to help as much as I can (even if that's just publicly endorsing it as the replacement). I've added you as an owner of the currently-empty
travis-cargopackage on crates.io.