Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hashmap: don't initialize devt_hash_ops in the header #212

Merged
merged 1 commit into from Nov 5, 2021
Merged

hashmap: don't initialize devt_hash_ops in the header #212

merged 1 commit into from Nov 5, 2021

Conversation

kaniini
Copy link
Member

@kaniini kaniini commented Nov 5, 2021

It is initialized in hashmap.c:338, and should not be initialized
in the header.

Fixes: #191
Signed-off-by: Ariadne Conill ariadne@dereferenced.org

@kaniini
hashmap: don't initialize devt_hash_ops in the header
cd4cf17 
It is initialized in hashmap.c:338, and should not be initialized
in the header.

Fixes: #191
Signed-off-by: Ariadne Conill <ariadne@dereferenced.org>
@kaniini kaniini requested a review from bbonev November 5, 2021 01:55
bbonev
bbonev approved these changes Nov 5, 2021
View reviewed changes
Copy link
Member

@bbonev bbonev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#if SIZEOF_DEV_T != 8 is true on 32bit only, so this went unnoticed.

Good catch!

@bbonev bbonev merged commit 24bbbf7 into master Nov 5, 2021
@bbonev bbonev deleted the fix/issue-191-devt_hash_ops branch June 12, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbonev bbonev bbonev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error: redefinition of 'devt_hash_ops' const struct hash_ops devt_hash_ops
2 participants
@kaniini @bbonev