Let libudev find hwdb.bin under UDEV_HWDB_BIN #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add patch(es) to the respective man pages before we can merge |
* src/libudev/libudev-hwdb.c (get_hwdb_bin_paths): New function, replacing hwdb_bin_paths. (struct udev_hwdb): New bin_paths field. (udev_hwdb_new): Initialize it with get_hwdb_bin_paths. (udev_hwdb_validate): Use the bin_paths field to find hwdb.bin. (udev_hwdb_unref): Free the bin_paths field. * src/libudev/libudev.h: Warn about UDEV_HWDB_BIN. * man/udev.xml: Mention run-time UDEV_HWDB_BIN. * man/udev.7: Re-generate.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear eudev developers,
It is not very convenient that libudev can only use /etc/udev/hwdb.bin or /lib/udev/hwdb.bin. For Guix, we would like that the hwdb.bin file would be compiled for every used combination of hwdb-providing packages, and then let different users choose the file to use at run-time. The minimum that would work would be to add a single (absolute) file name under UDEV_HWDB_BIN, so that libudev would try that file first (and then, fall back to /etc and /lib). This is NOT a path variable. Libudev cannot use multiple hwdb.bin files anyway, so there is no need for a path.
The list of files to try for hwdb.bin is now dynamic, and so we should account for malloc failures. However,
udev_hwdb_validateis not supposed to be able to fail. So, I think it should be OK to store the list of files to try in the struct udev_hwdb instance.What do you think?
Best regards,
Vivien