Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output of color codes in Windows results in just control codes #148

Closed
gregersn opened this issue Jun 3, 2015 · 3 comments
Closed

Output of color codes in Windows results in just control codes #148

gregersn opened this issue Jun 3, 2015 · 3 comments

Comments

@gregersn
Copy link

gregersn commented Jun 3, 2015

Since Windows doesn't support the color codes used by ColorLogger directly, the output contains a lot of garbage.

However, as suggested by the python-colorlog github page:

On Windows, requires colorama to work properly. A dependancy on colorama is included as an optional package dependancy - depending on colorlog[windows] instead of colorlog will ensure it is included when installing.

also, by adding

 import colorama

and

colorama.init() at the start of main() in cli.py output is much more sane.

@krallin
Copy link
Collaborator

krallin commented Jun 3, 2015

Can you try this branch:

https://github.com/koenbok/Cactus/compare/add-colorama?expand=1

Thanks!

@gregersn
Copy link
Author

gregersn commented Jun 3, 2015

Tested, and it works!

@krallin
Copy link
Collaborator

krallin commented Jun 3, 2015

Excellent; thanks!

@krallin krallin closed this as completed Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants