Skip to content

Commit

Permalink
turn mock request into a stream (#169)
Browse files Browse the repository at this point in the history
* http.IncomingMessage extends stream.Readable extends NodeJS.ReadableStream extends NodeJS.EventEmitter. a mock request that implements stream.Readable gets us a little closer to http.IncomingMessage than events.EventEmitter.

* test that the mocked request is an EventEmitter and a Readable stream
  • Loading branch information
abacaphiliac authored and eugef committed Jun 4, 2018
1 parent b21842b commit a8c44c0
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
3 changes: 2 additions & 1 deletion lib/mockRequest.js
Expand Up @@ -34,6 +34,7 @@ var url = require('url');
var typeis = require('type-is');
var accepts = require('accepts');
var EventEmitter = require('events').EventEmitter;
var Readable = require('stream').Readable;

var standardRequestOptions = [
'method', 'url', 'originalUrl', 'baseUrl', 'path', 'params', 'session', 'cookies', 'headers', 'body', 'query', 'files'
Expand All @@ -58,7 +59,7 @@ function createRequest(options) {
}

// create mockRequest
var mockRequest = Object.create(EventEmitter.prototype);
var mockRequest = new Readable();
EventEmitter.call(mockRequest);

mockRequest.method = options.method ? options.method : 'GET';
Expand Down
8 changes: 8 additions & 0 deletions test/lib/mockRequest.spec.js
Expand Up @@ -32,6 +32,14 @@ describe('mockRequest', function() {
expect(request).to.be.an('object');
});

it('should be an EventEmitter', function() {
expect(request).to.be.an.instanceof(require('events').EventEmitter);
});

it('should be a Readable stream', function() {
expect(request).to.be.an.instanceof(require('stream').Readable);
});

it('should expose Express Request object methods', function() {
expect(request).to.have.property('get');
expect(request.get).to.be.a('function');
Expand Down

0 comments on commit a8c44c0

Please sign in to comment.