Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

Maybe default editor templates should have pascal units in code subdirectory #7

Open
and3md opened this issue Mar 15, 2021 · 3 comments
Assignees

Comments

@and3md
Copy link
Collaborator

and3md commented Mar 15, 2021

After rereading the tutorial, I noticed that we are telling users to rearrange pascal modules in the default project template. If it is useful in such a simple project, in my opinion we should not require it from users but improve our project templates. If we do that 4.2 tutorial section (Moving units) can be deleted.

After playing some time with editor I agree with @eugeneloza that moving all pascal modules to code directory make navigation in project easier and looks better to me.

@eugeneloza @michaliskambi How about make this change in editor? Maybe this issue should go to CGE repository.

@michaliskambi
Copy link
Collaborator

Indeed, I wanted to change it in templates and all examples in CGE. I'll do it ASAP :)

michaliskambi added a commit to castle-engine/castle-engine that referenced this issue Mar 16, 2021
subdirectory

See eugeneloza/castle-editor-tutorial#7

Also, while I was going over ~all examples:

- remove random Makefile files (it was ~random where I placed them, and they were not synchronized, each contained a random subset of CGE platforms).

- set consistent qualified_name .

- make dragon_spine_demo and map_viewer and some other projects more consistent (project name should match the lpr/lpi name etc.)

- avoid some castleconf.inc usage in example code. Only CGE units should use it.

- make sure all examples have lpi/lpr to build them by Lazarus, using `castle-engine generate-program`.
@michaliskambi
Copy link
Collaborator

This is now done on CGE side by castle-engine/castle-engine@1f6514f . All templates and most examples now have a code/ subdirectory.

I also did somewhat-related castle-engine/castle-engine@e864725 : the templates now contain a sensible .gitignore and README.md that looks good on GitHub out-of-the-box :)

I'm leaving the issue open -- because hopefully @eugeneloza can now simplify the text.

@michaliskambi michaliskambi removed their assignment Mar 16, 2021
@eugeneloza
Copy link
Owner

Yeah, many thanks @michaliskambi !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants