BAEL-1226 Checkstyle introduction. #3736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyasht
commented
Feb 26, 2018
| @@ -325,7 +325,8 @@ | |||
| <!-- Maven plugins --> | |||
| <cargo-maven2-plugin.version>1.6.0</cargo-maven2-plugin.version> | |||
| <findbugs-maven-plugin.version>3.0.4</findbugs-maven-plugin.version> | |||
|
|
|||
| <checkstyle-maven-plugin.version>3.0.0</checkstyle-maven-plugin.version> | |||
| <dependency.locations.enabled>false</dependency.locations.enabled> | |||
There was a problem hiding this comment.
Added this line so that build does not take a long time. If we remove this the following issue will happen:
https://stackoverflow.com/questions/26144541/why-am-i-getting-maven-error-unable-to-determine-if-resource-x-exists-in-http
speaktoabu
added a commit
to speaktoabu/tutorials
that referenced
this pull request
Apr 12, 2018
* BAEL-1498 Money into words (eugenp#3797) * Add tradukisto library * Implement MoneyIntoWords * Update the version of tradukisto library * Refactor MoneyIntoWords * Refactor * Refactor pom.xml * Refactor pom.xml * Refactor NumberWordConverter * BAEL-1498 Small refactoring * Test edge cases * BAEL-1498 Additional tests * removing unused imports * Delete README.md (eugenp#3796) * minor formatting work * Initialize grails web app * Add Student domain class * Add Student attributes * BAEL-1068 (eugenp#3456) * BAEL-1068 - Javadoc example classes * BAEL-1068 - Formatting change for pom.xml * Updated javadoc comments to reflect article example * Added javadoc tags for throws, deprecated, and version and a clause to throw an exception * BAEL-1599 * Add code for article "Mapping LOB Data in Hibernate" (eugenp#3778) * Add lob example * Migrate the XML Based Configuration to Java Based Configuration * modify tomcat dependency (eugenp#3806) * BAEL-1576 Guide to unirest (eugenp#3779) * BAEL-1546: Java 8 Math additions (eugenp#3805) * BAEL-1546: Java 8 Math additions * Applied feedback to Unit Tests * BAEL-1546 Added missing test annotations * BAEL-1609 Updated guava version from 21.0 to 24.0-jre * Request for BAEL-1584 (eugenp#3740) * Added for BAEL-1584 * updated for BAEL-1584 * Updated as per Suggestions from Josh, for BAEL-1584 * Removed wrapper class and updated few methods to return boolean instead of Integer * BAEL-1609 Added test for CountingOutputStream * BAEL-1588 Junit assertions (eugenp#3810) * Added JUnit Assertions code * Fix method spelling * Fix wrong assertion * Adding code and jUnits for BAEL-1435 * Ignored failing test * Ignored failing test * Bael 1611 (eugenp#3799) * Externalizable test * Guide to Externalizable interface +tests * serialize Community * Changes for handling capitalised xml elements * #BAEL-1549 Completed implementation of multipart upload (eugenp#3816) * Renamed test file and fix typo in method name * BAEL-1578: Hamcrest Object and Beans matchers. (eugenp#3820) * Remove constraints and redundant ID property * Remove generated test for Student domain * BAEL-1636 (eugenp#3825) * BAEL-1636 file upload with Spring Boot (nothing changes in the code per se, just the dependencies) * BAEL-1636 removed bogus dependencies * Updated rest-assured version because 2.9.0 is no longer on Central * Create service for managing students * Create controller for handling crud request * Create views * Add unit tests for controller * Add integration tests for StudentService * Bael 1532 (eugenp#3817) * Changes for BAEL1532 * Changes for BAEL_1532 * BAEL-1532-Added as module to parent project * zookeeper pom version upgrade * move plugin file * added link to article * BAEL-1567 (eugenp#3824) * BAEL-1412 add java 8 spring data features * BAEL-21 new HTTP API overview * BAEL-21 fix executor * BAEL-1432 add custom gradle task * BAEL-1567 add samples of cookie and session in serlvet * BAEL-1567 use stream api * BAEL-1554 - Guide to Flips (eugenp#3827) * BAEL-1554 - Flips code * BAEL-1554 - Flips code, round 2 * BAEL-1554 - Guide to Flips * BAEL-1554 - update read me * BAEL-1554 - rename "Thing" to "Foo" * Add data structures as a separate module (eugenp#3518) * Remove data structures from core-java * Add data-structures * Update README with links to articles * Add parent module reference * @lazy annotation (eugenp#3809) * Update .travis.yml (eugenp#3819) * Bael-1601: move servlet redirect vs forward to spring-boot-bootstrap module (eugenp#3792) * move servlet redirect vs forward to this module * Added Unit test for servlets * Cleaned Unit tests * Refactored styling of the Java files. * BAEL-1491 README (eugenp#3832) * BAEL-973: updated README * BAEL-1069: Updated README * BAEL-817: add README file * BAEL-1084: README update * BAEL-960: Update README * BAEL-1155: updated README * BAEL-1041: updated README * BAEL-973: Updated README * BAEL-1187: updated README * BAEL-1183: Update README * BAEL-1133: Updated README * BAEL-1098: README update * BAEL-719: add README.md * BAEL-1272: README update * BAEL-1272: README update * BAEL-1196: Update README * BAEL-1328: Updated README * BAEL-1371: Update README.md * BAEL-1371: Update README.md * BAEL-1278: Update README * BAEL-1326: Update README * BAEL-399: Update README * BAEL-1297: Update README * BAEL-1218: README * BAEL-1148 README update * BAEL-113 README * BAEL-1158 README * BAEL-1539: Update README * BAEL-1507 README update * BAEL-1178 README updated * BAEL-1462 README * BAEL-1491 README update * BAEL-1417 Spring Data with Spring Security (eugenp#3720) * Define beans for handling different message types in a lean chat app * Add class based spring beans configuration * Define spring configuration in XML for constructor based bean injection * Refactor package structure to separate constructor based bean injection code set from setter based bean injection code set * Define configuration and classes specific to setter-based bean injection. * Implement tests for constructor-based and setter-based bean injections * develop codes for explaining type erasure * Write unit tests for type erasure examples * Remove evaluation article code * Modify type erasure examples and unit tests * Modify type erasure examples and unit tests * Add expected exception in TypeErasureUnitTest * Correct grammar in class name * Implement File Manager app to demonstrate Polymorphism. Develop unit tests for Polymorphism article code * Add examples for static polymorphism * Change sysout statments to slf4j log info statements * Add assertions and expected errors check on Test * Add assertions and expected errors check on Test * Correct compile time error of symbol not found * Removed commented out non-compiling test. * Replace string concatenations with String.format * Replace string concatenations with String.format * Remove verbose file info descriptor and replace with simpler one * Add example codes for Hibernate Interceptors article Write tests for session-scoped and sessionFactory-scoped interceptors * Implement serializable on customInterceptorImpl * Implement examples for spring data with spring security integration * Remove webapp example implementations; too extensive * Changes for BAEL-1613 * change alg signature * BAEL-1609 Updated test to throw exception * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Create README.md * Update README.md * Update README.md * Update README.md * Update README.md * removed unnecessary class fixed test so that not all data is written at once * Update README.md * BAEL-1567 use optional (eugenp#3849) * BAEL-1412 add java 8 spring data features * BAEL-21 new HTTP API overview * BAEL-21 fix executor * BAEL-1432 add custom gradle task * BAEL-1567 add samples of cookie and session in serlvet * BAEL-1567 use stream api * BAEL-1567 fix optional * BAEL-1591: Tagging implementation with MongoDB. * Bael 1269 Intro to JSON Java (eugenp#3662) * Final commit * Made changes as per last review * Moved from core-java to json module * Interrupted thread before logging * Separated out JSON serialization to Java Object * Reverting access modifier * Servlet refactor (eugenp#3851) * add comment to clarify * update to boot 2 release * Added tags CRUD operations. * BAEL-1159 - Simplified example (eugenp#3853) * Squashed commit of the following: commit b31955df9638a6217a804e61faa230d8eacb293b Author: Juan Moreno <earth001@gmail.com> Date: Wed Feb 21 22:45:52 2018 -0300 Sample code for BAEL-1159 - Working with Kotlin and JPA - earth001@gmail.com * Squashed commit of the following: commit 4e6e27c914a401ee6bc599c7ffe913384137646a Author: Juan Moreno <earth001@gmail.com> Date: Wed Feb 21 23:26:20 2018 -0300 Fix package names commit b31955df9638a6217a804e61faa230d8eacb293b Author: Juan Moreno <earth001@gmail.com> Date: Wed Feb 21 22:45:52 2018 -0300 Sample code for BAEL-1159 - Working with Kotlin and JPA - earth001@gmail.com * Added sample with null fields * Removed unused dependency * BAEL-1159 - Simplified example * Changes for BAEL-1633 * BAEL-1226 Checkstyle introduction. (eugenp#3736) * BAEL-1226:- Changes for checkstyle * BAEL-1226: Changes for checkstyle * Changes for BAEL-1226:- Chnaged the file to match in article. * Formatting chnages. * BAEL-1226: Change for the pom * RxRelay Article Materials (eugenp#3859) * package structure (eugenp#3850) * Update README.md * BAEL-1554 (eugenp#3864) * BAEL-1554 - Flips code * BAEL-1554 - Flips code, round 2 * BAEL-1554 - Guide to Flips * BAEL-1554 - update read me * BAEL-1554 - rename "Thing" to "Foo" * BAEL-1554 - rename module to spring-4 * add: initial commit * add: functional endpoint and annotated controller * javafx main application * BAEL-1599 * BAEL-1612 (eugenp#3811) * bael-1612 * line * formatting, dst error * formatting * Update DaylightSavingTimeExamplesTest.java * Update DaylightSavingTimeJavaTimeExamplesTest.java * added article link (eugenp#3866) * BAEL-1565 (eugenp#3869) * BAEL-1565 * move BAEL-1565 code to testing-modules/mocks/mock-comparisons * Update DaylightSavingTimeJavaTimeExamplesTest.java * set default timezone * ignore long test * removed field "article" for clearer understanding * added article link * BAEL-1586 Modified logic to use forEach loop (eugenp#3879) * BAEL-1586 Modified logic to use forEach loop * BAEL-1586 Added Unit Test For Finding Average Given an Empty Array * Core Maven Plugins * BAEL-1649 Difference between @controller and @RestController (eugenp#3885) * Difference between @controller and @RestController * Difference between @controller and @RestController - test fix * BAEL-1577 : hamcrest core matchers examples added as test cases (eugenp#3887) * Update README.md * added article link * Add the non-Spring DynamoDB samples in the AWS module * JavaFX UI * Bael 1600 internationalization and localization (eugenp#3807) * BAEL-1600 Internationalization and Localization in Java 8 The essential code for the article. * BAEL-1600 Internationalization and Localization in Java 8 The essential code for the article. * BAEL-1600 Internationalization and Localization in Java 8 JUnit test names fixed. Default Timezones set. * BAEL-1600 Internationalization and Localization in Java 8 Default Timezones set. * BAEL-1510 - RxJava - Combining Observables (eugenp#3892) * Simplified examples and lambda expressions * Code for BAEL-1040 (eugenp#3897) * BAEL-1612 README (eugenp#3898) * BAEL-973: updated README * BAEL-1069: Updated README * BAEL-817: add README file * BAEL-1084: README update * BAEL-960: Update README * BAEL-1155: updated README * BAEL-1041: updated README * BAEL-973: Updated README * BAEL-1187: updated README * BAEL-1183: Update README * BAEL-1133: Updated README * BAEL-1098: README update * BAEL-719: add README.md * BAEL-1272: README update * BAEL-1272: README update * BAEL-1196: Update README * BAEL-1328: Updated README * BAEL-1371: Update README.md * BAEL-1371: Update README.md * BAEL-1278: Update README * BAEL-1326: Update README * BAEL-399: Update README * BAEL-1297: Update README * BAEL-1218: README * BAEL-1148 README update * BAEL-113 README * BAEL-1158 README * BAEL-1539: Update README * BAEL-1507 README update * BAEL-1178 README updated * BAEL-1462 README * BAEL-1491 README update * BAEL-1612: README update * Update ObservableCombineUnitTest.java (eugenp#3896) * Changes for BAEL-1653 * BAEL - 717 : Singleton EJB Beans. (eugenp#3883) * BAEL-717: Singleton EJB Bean Files for BAEL-717:Singleton EJB Bean. * BAEL-717: Singleton EJB Bean Corrected Indentation. * BAEL-717: Singleton EJB Bean Corrected Indentation. * BAEL-717: Singleton EJB Bean Corrected Indentation. * BAEL-717: Singleton EJB Bean Corrected Indentation. * BAEL-717: Singleton EJB Bean Changed artifactId value. * BAEL-717: Singleton EJB Bean. Added module for Singleton EJB Bean. * BAEL-717: Singleton EJB Bean. Removed Singleton EJB Bean Module. * BAEL-717: Singleton EJB Bean Changed the JNDI Lookup name. * BAEL-717: Singleton EJB Bean. Added the "singleton-ejb-bean" module. * BAEL-717: Singleton EJB Bean. Corrected Indentation. * BAEL-717: Singleton EJB Bean Corrected Indentation. * BAEL-717: Singleton EJB Bean. Corrected Indentation. * BAEL-717: Singleton EJB Bean. Corrected Indentation. * BAEL-717:Singleton EJB Bean. Corrected Indentation. * BAEL-717:Singleton EJB Bean. Corrected Indentation. * BAEL-1576 Added implementation for finding sum in a boxed integer array (eugenp#3901) * BAEL-1600 Internationalization in Java 8 (eugenp#3902) BigDecimal for currency formatting. * BAEL-1545 - Nats Tutorial (eugenp#3904) * BAEL-1579: Hamcrest custom matchers. (eugenp#3905) * BAEL-1579: Hamcrest custom matchers. * BAEL-1589: Removing hamcrest dependency test scope. * BAEL-1557 Intro to Apache OpenNlp * BAEL-1557 Intro to Apache OpenNlp * BAEL-1557 Code Formatting * BAEL-1489: Upgrading to Spring Boot 2 GA and using UserBuilder * BAEL-1489: Explicitely handing in empty authorities list * BAEL-1635: Spring Boot CLI (eugenp#3886) * BAEL-1635: Spring Boot CLI * Modified packages for consistent naming * Kotlin Read from File * BAEL-1510 README (eugenp#3918) * BAEL-973: updated README * BAEL-1069: Updated README * BAEL-817: add README file * BAEL-1084: README update * BAEL-960: Update README * BAEL-1155: updated README * BAEL-1041: updated README * BAEL-973: Updated README * BAEL-1187: updated README * BAEL-1183: Update README * BAEL-1133: Updated README * BAEL-1098: README update * BAEL-719: add README.md * BAEL-1272: README update * BAEL-1272: README update * BAEL-1196: Update README * BAEL-1328: Updated README * BAEL-1371: Update README.md * BAEL-1371: Update README.md * BAEL-1278: Update README * BAEL-1326: Update README * BAEL-399: Update README * BAEL-1297: Update README * BAEL-1218: README * BAEL-1148 README update * BAEL-113 README * BAEL-1158 README * BAEL-1539: Update README * BAEL-1507 README update * BAEL-1178 README updated * BAEL-1462 README * BAEL-1491 README update * BAEL-1612: README update * BAEL-1510: Updated README * Inheritance and Composition (Is-a vs Has-a relationship) in Java - BAEL-1598 (eugenp#3871) * Initial Commit * Fix package names * add: more tests * BAEL-1595 - JetS3t for S3 storage. (eugenp#3920) * Bael 1625 (eugenp#3831) * shutdown boot app * test the ctx.close() * application shutdown test * BAEL-1625 * /shutdown endpoint test * bring back the closeApplication * @ignore shutdown endpoint test * Change StandardCharsets to Charsets * changing classes of maven module * removing moved classes and resources * BAEL-1623 sample spring boot gradle project * Adding web3j contract deployment example (eugenp#3911) Committer: Alex Vargas <alexvargas1425@gmail.com> * BAEL-1531 Add class to connect to secured server (eugenp#3919) * BAEL-1557 Refactor * minor changes * bring back the maven * BAEL-1579: Renaming custom matcher and handling corner case. (eugenp#3928) * BAEL-1623 Added an bootJar block in build.gradle * BAEL-1040 (eugenp#3929) * Code for BAEL-1040 * Amended code for BAEL-1040 * Amended tests for BAEL-1040 * added example code for BAEL-1682 * updated properties file for example * BAEL-1512 Filtering Observables in RxJava (eugenp#3931) * Added test cases for RxJava Filtering Operators * Added @ignore on TimeFiltering tests * Added another bootJar manifest configuration example commented out * Removed redundant bootJar block * Added TestScheduler to TimeFiltering operators test (eugenp#3935) * BAEL-1602 (eugenp#3926) * Implement examples for ASCII Art in Java * Remove deprecated use of ControllerClassNameHandlerMapping * Implement examples for JSTL core tag * Implement examples for JSTL formatting tags * Implement examples for JSTL SQL tags * Implement examples for JSTL XML tags * Implement examples for JSTL function tags * Setup controllers package scanning * Add link to article on jstl * naming change * Add jstl maven repository * updated example source code * BAEL-1562 - Working with Fragments in Thymeleaf (eugenp#3868) * BAEL-1562 - Thymeleaf sample working * BAEL-1562 Code added for Fragments sample * BAEL-1562 - Last correction for the test * BAEL-1562 - Thymeleaf sample working * BAEL-1562 Code added for Fragments sample * BAEL-1562 - Last correction for the test * Examples for BAEL-1169 (eugenp#3934) * BAEL-1562 - Thymeleaf dependency updated (eugenp#3940) * BAEL-1562 - Thymeleaf sample working * BAEL-1562 Code added for Fragments sample * BAEL-1562 - Last correction for the test * BAEL-1562 - Thymeleaf sample working * BAEL-1562 Code added for Fragments sample * BAEL-1562 - Last correction for the test * Updates Thymeleaf version to 3.0.9.RELEASE * update BAEL-1565 test method names (eugenp#3943) * Before and after Junit annotations * testing work * testing work * pom cleanup * BAEL-1530 - Guide to java.lang.System (eugenp#3616) * Different types of bean injection in Spring - eval * Different types of bean injection in Spring - eval - changed to java config * Different types of bean injection in Spring - eval - unit tests and fixes * BAEL-1530 - Guide to java.lang.System * removed eval article stuff * updated unit tests: removed sysouts and unrelated stuff * updated examples for easiness. refactoring. * fixed typos, identified by unit tests * broken into multiple unit tests * Thymeleaf conditionals (eugenp#3949) * different types of thymeleaf conditionals * improved thymeleaf conditionals * asserting exceptions in junit4 and junit5 code sample added * BAEL-1648 - Measure Time Elapsed in Java * Initialize facade subproject * Add classes of complex car subsystem * Implement facade for carsystem * Add unit tests for CarEngineFacade * Fix test names * move javafx code to a separate module * move javafx code to a separate module * Removed AlternateEntryPoint * change test names * exclude libraries * Update README.md * refactoring test names * Rename test (eugenp#3971) * Build fix (eugenp#3972) * Fixed a unit test and commented others to fix the build failures * Rename test * Update README (eugenp#3953) * BAEL-973: updated README * BAEL-1069: Updated README * BAEL-817: add README file * BAEL-1084: README update * BAEL-960: Update README * BAEL-1155: updated README * BAEL-1041: updated README * BAEL-973: Updated README * BAEL-1187: updated README * BAEL-1183: Update README * BAEL-1133: Updated README * BAEL-1098: README update * BAEL-719: add README.md * BAEL-1272: README update * BAEL-1272: README update * BAEL-1196: Update README * BAEL-1328: Updated README * BAEL-1371: Update README.md * BAEL-1371: Update README.md * BAEL-1278: Update README * BAEL-1326: Update README * BAEL-399: Update README * BAEL-1297: Update README * BAEL-1218: README * BAEL-1148 README update * BAEL-113 README * BAEL-1158 README * BAEL-1539: Update README * BAEL-1507 README update * BAEL-1178 README updated * BAEL-1462 README * BAEL-1491 README update * BAEL-1612: README update * BAEL-1510: Updated README * BAEL-1169 README * BAEL-1598: README update * BAEL-1372: Adding jUnits for Testing Netty with EmbeddedChannel article (eugenp#3973) * [tlinh2110] BAEL 1684 Init (eugenp#3937) * BAEL-1602 (eugenp#3963) * Implement examples for ASCII Art in Java * Remove deprecated use of ControllerClassNameHandlerMapping * Implement examples for JSTL core tag * Implement examples for JSTL formatting tags * Implement examples for JSTL SQL tags * Implement examples for JSTL XML tags * Implement examples for JSTL function tags * Setup controllers package scanning * Add link to article on jstl * naming change * Add jstl maven repository * Migrate example codes for Guide to JSTL to spring-mvc-forms-jsp module * Add view resolver order to define priority * Remove guide to jstl example codes from spring-mvc-xml module * Remove guide to jstl examples in spring-mvc-xml module after merge * Update link to article * Fail the build when naming conventions violated (eugenp#3974) * Failing build if unit test name does not follow one of the following conventions : ..IntegrationTest, ..LongRunningUnitTest, ..ManualTest, ..JdbcTest, ..LiveTest * Custom PMD Rules project * Fixed this issue when unit test classes were not being scanned by custom PMD rule (This happened after I pulled code from upstream project) * Don't fail the build if PMD custom rule fails * Reconfigure PMD * Reformat POM * Adjust PMD rules * Rename test * Update UnitTestNamingConventionRule.java (eugenp#3978) * 08.04.2018 (eugenp#3954) * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Create README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Create README.md * Update README.md * Update README.md * Create README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Create README.md * Update README.md * Update README.md * Create README.md * Update README.md * Update README.md * Create README.md * Update README.md * Update README.md * Update README.md * NatsClient refactor (eugenp#3914) * Refactor (eugenp#3923) * NatsClient refactor * Use lambda * FileReader idiomatic refactor (eugenp#3936) * Bael 1585 (eugenp#3750) * Different Types of Bean Injection in Spring * BAEL-1585 * Revert "Different Types of Bean Injection in Spring" This reverts commit ae47827. * Revert "BAEL-1585" This reverts commit e792f17. * BAEL-1585 * rev1 * [BAEL-1615] Code to support article. (eugenp#3867) * [BAEL-1615] Code to support article. * Adding example of provides...with * Adding uses to main module * Array to List tests (eugenp#3960) * BAEL-1592 (eugenp#3773) * Injecting Prototype Beans into Singleton Instance * removed final keywords from the test * BAEL-1484: Synchronous OpenCSV (eugenp#3784) * BAEL-1484: Synchronous OpenCSV * corrected pom.xml and package * Refactored for future async example * Resource Link * Rename MetricTypeTest (eugenp#3989)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review this commit for BAEL-1226. I have made it similar to Findbugs.
Regards,
Shreyash