-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling escaped single quotes within comments. #63
Conversation
Good catch! [Looking into your PR...] I'm not against dollar-quoting but I prefer the traditional way. |
I thought about going through whole code base and wherever it would make sense replacing |
If you are interested I also got your tests running within docker (to make it easier to test without having to install all of the dependencies locally) |
quote_literal was introduced in version |
I ended up adding new method to your |
I added escaping for enum labels too. |
This bug was reported in PR #63. Thanks @grzegorzk
Commit 725406a implements it as I suggested in #63 (comment) |
If comments were containing escaped single quote then script generated by
pgquarrel
was broken. Simple fix to use dollar-quotes fixes the problem.