Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: no more panic on empty env variables #28

Merged
merged 1 commit into from
Nov 13, 2023
Merged

fix: no more panic on empty env variables #28

merged 1 commit into from
Nov 13, 2023

Conversation

puffitos
Copy link
Collaborator

Motivation

Fixes #26

Changes

  • Added a simple if check to make sure the envFrom is not nil before accessing it.
  • Added a test to make sure something similar doesn't happen again

@puffitos
fix: no more panic on empty env variables
df3eb87 
Signed-off-by: Bruno Bressi <bruno.bressi@telekom.de>
@puffitos puffitos requested a review from eumel8 November 13, 2023 15:08
@puffitos puffitos self-assigned this Nov 13, 2023
eumel8
eumel8 approved these changes Nov 13, 2023
View reviewed changes
Copy link
Owner

@eumel8 eumel8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eumel8 eumel8 merged commit 1b4f7c0 into main Nov 13, 2023
13 checks passed
@eumel8 eumel8 deleted the fix/panic branch November 13, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eumel8 eumel8 eumel8 approved these changes

Assignees

@puffitos puffitos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

panic on getPubKeyFromEnv
2 participants
@puffitos @eumel8