Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/noverification event #31

Merged
merged 4 commits into from
Dec 15, 2023
Merged

Feat/noverification event #31

merged 4 commits into from
Dec 15, 2023

Conversation

puffitos
Copy link
Collaborator

Motivation

Addresses #30

Changes

  • Moved the EventBroadcaster to the cosign webhook server struct, as there was no need to explicitly create a new instance each time an event should be transmitted
  • Added a new "Event" (a string really), to indicate that no verification was done
  • Added a new function to search for the public key to be used for verification - if no key is found, no verification can be done → emit the new
  • Added 2 new E2E tests to test the event emission
  • Cleanup on repository
  • Some new make targets for E2E and doc update

Tests

E2E tests, which were manually observed as well :)

@puffitos puffitos self-assigned this Dec 15, 2023
@eumel8 eumel8 merged commit 982629b into main Dec 15, 2023
12 of 13 checks passed
@eumel8 eumel8 deleted the feat/noverification-event branch December 15, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@puffitos puffitos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@puffitos @eumel8