[UPDATE] Add unit test for utils file and refactoring ZeroLen function

Signed-off-by: poyaz <pooya_azarpour@yahoo.com>
eunames · Apr 11, 2024 · df889cb · df889cb
1 parent 22de53e
commit df889cb
Show file tree

Hide file tree

Showing 2 changed files with 603 additions and 3 deletions.
diff --git a/operator/utils/utils.go b/operator/utils/utils.go
@@ -23,9 +23,26 @@ func RandomStringGenerator(n int) string {
 }
 
 func ZeroLen(v interface{}) bool {
-	return v == nil ||
-		(reflect.ValueOf(v).Kind() == reflect.Ptr && reflect.ValueOf(v).IsNil()) ||
-		(reflect.ValueOf(v).Kind() == reflect.Ptr && !reflect.ValueOf(v).IsNil() && reflect.ValueOf(v).Elem().Len() == 0)
+	if v == nil {
+		return true
+	}
+
+	vv := reflect.ValueOf(v)
+	if vv.Kind() == reflect.Ptr {
+		if vv.IsNil() {
+			return true
+		}
+		vv = vv.Elem()
+	}
+	if !(vv.IsValid() && !vv.IsZero()) {
+		return true
+	}
+	switch vv.Kind() {
+	case reflect.Array, reflect.Chan, reflect.Map, reflect.Slice, reflect.String:
+		return vv.Len() == 0
+	}
+
+	return true
 }
 
 func AppendTLSOptionsArgs(opts *k8upv1.TLSOptions, prefixArgName ...string) []string {