add nix flake #261
Merged
add nix flake #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Hi, Thanks for your contributions! |
|
Any progress on this pr？Is it ready for review? |
flake: complete eunomia-bpf reproducible build This commit brings: - Fix issue mentioned in 158 - Update way of building ecli to adapt code changes - Add dev env with full eunomia-bpf toolchain flake: add pre-commit-hooks This commit adds pre commit check based on nix flake. chore: apply suggestions from flake check - Apply format suggestion from black - Rename file with space-separated names, which is not recommend on unix system flake: add wasm-bpf cli to dev env flake: devShell subdivision flake: sync bpftool to wasm-bpftool branch doc: fix display error in README flake: fetch vmlinux chore: update deprecated lock flake: adapt code changes on master flake: add missing include flake: add apps fix: cargo lock mismatch Previous version of Cargo.lock show `error: no matching package named bpf-oci found`. fix: nix build ecli flake: fix bpftool version
15 tasks
ocfox
approved these changes
Oct 12, 2023
flake.nix
Outdated
Comment on lines
32
to
42
| nativeBuildInputs = with pkgs; [ | ||
| pkg-config | ||
| zlib.static | ||
| elfutils | ||
| zlib | ||
| openssl.dev | ||
| cargo | ||
| rustc | ||
| rustPlatform.cargoSetupHook | ||
| rustPlatform.bindgenHook | ||
| ]; |
There was a problem hiding this comment.
openssl, elfutils and zlib should belong to buildInputs.
flake.nix
Outdated
Comment on lines
48
to
52
| installPhase = '' | ||
| mkdir -p $out/bin | ||
| install -Dm 755 target/release/ecli-rs $out/bin/ | ||
| install -Dm 755 target/release/ecli-server $out/bin/ | ||
| ''; |
flake.nix
Outdated
Comment on lines
72
to
75
| installPhase = '' | ||
| mkdir -p $out/bin | ||
| cp $src/bin/ecli-server $out/bin/ecli-server | ||
| ''; |
flake.nix
Outdated
Comment on lines
104
to
113
| buildPhase = '' | ||
| cd compiler/cmd | ||
| export OUT_DIR=. | ||
| cargo build --release | ||
| ''; | ||
| installPhase = '' | ||
| mkdir -p $out/bin | ||
| chmod +x target/release/ecc-rs | ||
| cp target/release/ecc-rs $out/bin/ecc | ||
| ''; |
|
I clicked approve by mistake, please ignore it. Thanks for your contribution. |
|
Before merging, some conflicts need to be resolved. @oluceps could you help with this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This pull request adds flake.nix, to simplify packaging process.
Use
nix bundle --bundler github:ralismark/nix-appimage .#ecli-rs,nix bundle --bundler github:ralismark/nix-appimage .#ecli-serverto create a static linked AppImage file.NOTE: this requires
ecli/Cargo.lockexists and added into git tree (git add ecli/Cargo.lock -f), but no need to commit it.P.S: According to Cargo Book, "If you’re building an end product, which are executable like command-line tool or an application, or a system library with crate-type of staticlib or cdylib, check Cargo.lock into git."
I've tested that
nix bundle --bundler github:NixOS/bundlers#toDockerImage .#ecli-rsalso works well, producing a ~27M docker image.See also: #258
Type of change
New feature (non-breaking change which adds functionality)
How Has This Been Tested?
N/A
Checklist