Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecli: fix extra parameters #323

Merged
merged 1 commit into from Dec 17, 2023
Merged

Conversation

Officeyutong
Copy link
Contributor

This PR allows call to ecli like ecli run package.json -h, where -h would be passed to the ebpf program

root@mnfe-pve:~/eunomia-bpf/examples/bpftools/bootstrap# ecli-rs run ./package.json -h
Error: Failed to run native eBPF program

Caused by:
    Bpf error: Failed to parse argument: A simple eBPF program
    
    
    Usage: prog [OPTIONS]
    
    Options:
          --verbose
              Whether to show libbpf debug information
          --min_duration_ns <min_duration_ns>
              Set value of `unsigned long long` variable min_duration_ns
      -h, --help
              Print help
      -V, --version
              Print version
    
    Built with eunomia-bpf framework.
    See https://github.com/eunomia-bpf/eunomia-bpf for more information.
    
root@mnfe-pve:~/eunomia-bpf/examples/bpftools/bootstrap# 

@Officeyutong Officeyutong marked this pull request as ready for review December 15, 2023 18:12
@auto-assign auto-assign bot requested a review from yunwei37 December 15, 2023 18:12
@yunwei37 yunwei37 changed the title Make ecli accept extra arguments to ebpf program without double hyphens ecli: fix extra parameters Dec 17, 2023
@yunwei37 yunwei37 merged commit a4b30f4 into eunomia-bpf:master Dec 17, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants