Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support template for pull request #15

Closed
yeonns opened this issue Jul 3, 2022 · 0 comments · Fixed by #27
Closed

support template for pull request #15

yeonns opened this issue Jul 3, 2022 · 0 comments · Fixed by #27
Assignees
@nodobi
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@yeonns
Copy link
Member

yeonns commented Jul 3, 2022

Description

We will have many contributors in euphony-collector, so it is nice to support pull request template for good communication.
Contents can be "checklist", "pr type" and so on.
We need to compare other open source's template and apply ours.
If you feel hard to figure out how to resolve this issue, please refer #9 and check @designe 's comments.
@yeonns yeonns added documentation Improvements or additions to documentation good first issue Good for newcomers labels Jul 3, 2022
@nodobi nodobi mentioned this issue Jul 30, 2022
Merged
@designe designe linked a pull request Jul 30, 2022 that will close this issue
Create pull-request template #27
Merged
yeonns pushed a commit that referenced this issue Jul 31, 2022
@nodobi
docs: create pull request template (#15)
52e7012 
* Create 'Pull-Request' template #15

* Rename PULL_REQUEST_TEMPLATE to PULL_REQUEST_TEMPLATE.md

* Update PULL_REQUEST_TEMPLATE.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nodobi nodobi

Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create pull-request template
2 participants
@yeonns @nodobi