Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test && commit || revert scripts #23

Merged
merged 11 commits into from
Nov 23, 2018

Conversation

jbruggem
Copy link
Contributor

  • Adds Elixir scaffold
  • Adds the two scripts
  • Adds build and test scripts for Java, JS, Elixir and Python

@Malian
Copy link
Contributor

Malian commented Nov 23, 2018

  • Several files have no new line at the end.
  • Do you plan to use btcr and tcr like this ../../scripts/{tcr|btcr} when you are in a specific scaffold?
  • I prefer using a folder called bin instead of scripts 😜
  • I'll add the build and test script for PHP. Do you prefer a new commit in this branch or a new branch?

@jbruggem
Copy link
Contributor Author

jbruggem commented Nov 23, 2018

  • Several files have no new line at the end.

thanks

  • Do you plan to use btcr and tcr like this ../../scripts/{tcr|btcr} when you are in a specific scaffold?

yes

  • I prefer using a folder called bin instead of scripts stuck_out_tongue_winking_eye

ok 😁

  • I'll add the build and test script for PHP. Do you prefer a new commit in this branch or a new branch?

new branch :). Thanks !

@jbruggem jbruggem merged commit dc7a806 into master Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants