Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opencv version 4 not supported #35

Closed
nick-walkden opened this issue Feb 5, 2019 · 3 comments
Closed

Opencv version 4 not supported #35

nick-walkden opened this issue Feb 5, 2019 · 3 comments
Labels
compatibility Related to environment or dependency compatibility

Comments

@nick-walkden
Copy link

I think this just needs a fix to the if statement in the do_fit function in the calibration class.
@ssilburn ssilburn added the compatibility Related to environment or dependency compatibility label Feb 5, 2019
ssilburn added a commit that referenced this issue Feb 5, 2019
@ssilburn
Fix explicit check for OpenCV version == 3 causing the Fitter class t…
9a39823 
…o try using the OpenCV 2 style call to cv2.calibrate_camera when actually using OpenCV 4 (Issue #35). Increment patch version to 2.1.2.
@ssilburn
Copy link
Collaborator

ssilburn commented Feb 5, 2019

Thanks Nick, hadn't spotted this! Now changed on the master branch. In general I should check if there are any other issues with changes from OpenCV 3 > 4; I haven't done any testing of that at all myself yet. I'll leave this issue open to remind me.

@nick-walkden
Copy link
Author

Great, thanks! I'm sure I'll run into more of these if they exist in the code so i'll document them here when I do.

@ssilburn
Copy link
Collaborator

Now fixed on the master branch and will be in the 2.2.0 release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compatibility Related to environment or dependency compatibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nick-walkden @ssilburn