Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

structure for CV #129

Merged
merged 10 commits into from
Jun 14, 2023
Merged

structure for CV #129

merged 10 commits into from
Jun 14, 2023

Conversation

larsbuntemeyer
Copy link
Contributor

@larsbuntemeyer larsbuntemeyer commented Apr 21, 2023

implement CMIP6 Cordex vocabulary:

  • adds mip_era keyword to cx.cordex_domain
  • rename short_name to domain_id keyword

closes #110

@larsbuntemeyer larsbuntemeyer self-assigned this Apr 21, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2023

Codecov Report

Merging #129 (99ac8ef) into master (b86969a) will increase coverage by 0.08%.
The diff coverage is 91.42%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
+ Coverage   80.95%   81.04%   +0.08%     
==========================================
  Files          23       23              
  Lines        1239     1250      +11     
==========================================
+ Hits         1003     1013      +10     
- Misses        236      237       +1     
Flag Coverage Δ
unittests 81.04% <91.42%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cordex/domain.py 81.70% <90.00%> (+1.18%) ⬆️
cordex/cf.py 100.00% <100.00%> (ø)
cordex/transform.py 96.36% <100.00%> (-0.91%) ⬇️

@larsbuntemeyer larsbuntemeyer merged commit f4d2ceb into master Jun 14, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consistent vocabulary for domain_id
2 participants