Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preprocessing fixes and upates #36

Merged
merged 6 commits into from
Jan 12, 2022
Merged

Conversation

larsbuntemeyer
Copy link
Contributor

some fixes for the preprocessing module

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2021

Codecov Report

Merging #36 (f26f6c2) into master (a2e1ff1) will decrease coverage by 5.93%.
The diff coverage is 49.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
- Coverage   87.12%   81.18%   -5.94%     
==========================================
  Files          17       18       +1     
  Lines         598      675      +77     
==========================================
+ Hits          521      548      +27     
- Misses         77      127      +50     
Flag Coverage Δ
unittests 81.18% <49.48%> (-5.94%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cordex/preprocessing/__init__.py 100.00% <ø> (ø)
cordex/preprocessing/known_issues.py 11.11% <11.11%> (ø)
cordex/core/domain.py 81.56% <47.82%> (-12.28%) ⬇️
cordex/preprocessing/preprocessing.py 80.09% <56.41%> (-6.50%) ⬇️
cordex/core/cf.py 100.00% <100.00%> (ø)

@larsbuntemeyer larsbuntemeyer marked this pull request as ready for review December 5, 2021 18:45
@larsbuntemeyer larsbuntemeyer changed the title added vertices replacement preprocessing fixes and upates Dec 11, 2021
@larsbuntemeyer larsbuntemeyer merged commit 4f0c060 into master Jan 12, 2022
@larsbuntemeyer larsbuntemeyer deleted the preprocessing_fixes branch January 12, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants