Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added rounding of coordinate numbers #61

Merged
merged 6 commits into from
Jun 22, 2022
Merged

added rounding of coordinate numbers #61

merged 6 commits into from
Jun 22, 2022

Conversation

larsbuntemeyer
Copy link
Contributor

@larsbuntemeyer larsbuntemeyer commented Jun 22, 2022

According to #60, we can get rounding errors in the coordinate numbers. We now restrict precision of coordinates to 14 digits.

closes #60

@larsbuntemeyer
Copy link
Contributor Author

pre-commit is fixed in master

@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2022

Codecov Report

Merging #61 (c21f2c6) into master (8df5b9e) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
+ Coverage   79.28%   79.34%   +0.05%     
==========================================
  Files          18       19       +1     
  Lines         758      760       +2     
==========================================
+ Hits          601      603       +2     
  Misses        157      157              
Flag Coverage Δ
unittests 79.34% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cordex/core/config.py 100.00% <100.00%> (ø)
cordex/core/domain.py 75.22% <100.00%> (+0.11%) ⬆️

@larsbuntemeyer larsbuntemeyer merged commit 4e0c4da into master Jun 22, 2022
@larsbuntemeyer larsbuntemeyer deleted the rounding branch June 22, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rounding errors
2 participants