Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added cmor code from pyremo #68

Merged
merged 14 commits into from
Aug 15, 2022
Merged

added cmor code from pyremo #68

merged 14 commits into from
Aug 15, 2022

Conversation

larsbuntemeyer
Copy link
Contributor

@larsbuntemeyer larsbuntemeyer commented Aug 5, 2022

adds cmor code from pyremo.cmor and adatps it for use with cosmo by letting the user pass a mapping_table keyword argument, see #26. features include:

  • unit checks and conversion to table unit if necessary
  • automatic table fetching
  • resampling to table frequencies if required.
  • adding missing coordinate definitions (e.g., time bounds, vertices, etc..)
  • checks against archive specifications.
  • add code from pyremo
  • add mapping_table keyword
  • add tests

@larsbuntemeyer larsbuntemeyer changed the title added initial cmor code from pyremo added cmor code from pyremo Aug 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2022

Codecov Report

Merging #68 (670f4c3) into master (6e380ba) will decrease coverage by 12.79%.
The diff coverage is 25.10%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #68       +/-   ##
===========================================
- Coverage   79.03%   66.23%   -12.80%     
===========================================
  Files          19       20        +1     
  Lines         763     1001      +238     
===========================================
+ Hits          603      663       +60     
- Misses        160      338      +178     
Flag Coverage Δ
unittests 66.23% <25.10%> (-12.80%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cordex/cmor/cmor.py 21.67% <21.67%> (ø)
cordex/cmor/utils.py 72.72% <42.85%> (-18.02%) ⬇️
cordex/cmor/__init__.py 100.00% <100.00%> (ø)

@larsbuntemeyer larsbuntemeyer marked this pull request as ready for review August 15, 2022 14:22
@larsbuntemeyer larsbuntemeyer merged commit 5f7b494 into master Aug 15, 2022
@larsbuntemeyer larsbuntemeyer deleted the cmor branch August 15, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants